theluyuan/vue3-yuanma
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
1d5a9eb7c1
vue3-yuanma/.github/contributing.md
Turtuvshin Byambaa 7c90aa5539 chore: fix typo in contributing guide (#589)
2020-01-07 11:33:22 +01:00

13 KiB
Raw Blame History

Vue.js Contributing Guide

Hi! I'm really excited that you are interested in contributing to Vue.js. Before submitting your contribution, please make sure to take a moment and read through the following guidelines:

Issue Reporting Guidelines

Pull Request Guidelines

  • Checkout a topic branch from a base branch, e.g. master, and merge back against that branch.

  • If adding a new feature:

    • Add accompanying test case.
    • Provide a convincing reason to add this feature. Ideally, you should open a suggestion issue first and have it approved before working on it.

  • If fixing bug:

    • If you are resolving a special issue, add (fix #xxxx[,#xxxx]) (#xxxx is the issue id) in your PR title for a better release log, e.g. update entities encoding/decoding (fix #3899).
    • Provide a detailed description of the bug in the PR. Live demo preferred.
    • Add appropriate test coverage if applicable. You can check the coverage of your code addition by running yarn test --coverage.

  • It's OK to have multiple small commits as you work on the PR - GitHub can automatically squash them before merging.

  • Make sure tests pass!

  • Commit messages must follow the commit message convention so that changelogs can be automatically generated. Commit messages are automatically validated before commit (by invoking Git Hooks via yorkie).

  • No need to worry about code style as long as you have installed the dev dependencies - modified files are automatically formatted with Prettier on commit (by invoking Git Hooks via yorkie).

Development Setup

You will need Node.js version 10+, and Yarn.

After cloning the repo, run:

$ yarn # install the dependencies of the project

A high level overview of tools used:

Scripts

yarn build

The build script builds all public packages (packages without private: true in their package.json).

Packages to build can be specified with fuzzy matching:

# build runtime-core only
yarn build runtime-core

# build all packages matching "runtime"
yarn build runtime --all

Build Formats

By default, each package will be built in multiple distribution formats as specified in the buildOptions.formats field in its package.json. These can be overwritten via the -f flag. The following formats are supported:

  • global:

    • For direct use via <script> in the browser. The global variable exposed is specified via the buildOptions.name field in a package's package.json.
    • Note: global builds are not UMD builds. Instead they are built as IIFEs.

  • esm-bundler:

    • Leaves prod/dev branches with process.env.NODE_ENV guards (to be replaced by bundler)
    • Does not ship a minified build (to be done together with the rest of the code after bundling)
    • For use with bundlers like webpack, rollup and parcel.
    • Imports dependencies (e.g. @vue/runtime-core, @vue/runtime-compiler)
      • Imported dependencies are also esm-bundler builds and will in turn import their dependencies (e.g. @vue/runtime-core imports @vue/reactivity)
      • This means you can install/import these deps without ending up with different instances of these dependencies

  • esm:

    • For usage via native ES modules imports (in browser via <script type="module">, or via Node.js native ES modules support in the future)
    • Inlines all dependencies - i.e. it's a single ES module with no imports from other files
      • This means you must import everything from this file and this file only to ensure you are getting the same instance of code.
    • Hard-coded prod/dev branches, and the prod build is pre-minified (you will have to use different paths/aliases for dev/prod)

  • cjs:

    • For use in Node.js server-side rendering via require().
    • The dev/prod files are pre-built, but are dynamically required based on process.env.NODE_ENV in index.js, which is the default entry when you do require('vue').

For example, to build runtime-core with the global build only:

yarn build runtime-core -f global

Multiple formats can be specified as a comma-separated list:

yarn build runtime-core -f esm,cjs

Build with Type Declarations

The --types flag will generate type declarations during the build and in addition:

  • Roll the declarations into a single .dts file for each package;
  • Generate an API report in <projectRoot>/temp/<packageName>.api.md. This report contains potential warnings emitted by api-extractor.
  • Generate an API model json in <projectRoot>/temp/<packageName>.api.json. This file can be used to generate a Markdown version of the exported APIs.

yarn dev

The dev script bundles a target package (default: vue) in a specified format (default: global) in dev mode and watches for changes. This is useful when you want to load up a build in an HTML page for quick debugging:

$ yarn dev

> rollup v1.19.4
> bundles packages/vue/src/index.ts → packages/vue/dist/vue.global.js...

  • The dev script also supports fuzzy match for the target package, but will only match the first package matched.

  • The dev script supports specifying build format via the -f flag just like the build script.

yarn test

The yarn test script simply calls the jest binary, so all Jest CLI Options can be used. Some examples:

# run all tests
$ yarn test

# run tests in watch mode
$ yarn test --watch

# run all tests under the runtime-core package
$ yarn test runtime-core

# run tests in a specific file
$ yarn test fileName

# run a specific test in a specific file
$ yarn test fileName -t 'test name'

Project Structure

This repository employs a monorepo setup which hosts a number of associated packages under the packages directory:

  • reactivity: The reactivity system. It can be used standalone as a framework-agnostic package.

  • runtime-core: The platform-agnostic runtime core. Includes code for the virtual dom renderer, component implementation and JavaScript APIs. Higher-order runtimes (i.e. custom renderers) targeting specific platforms can be created using this package.

  • runtime-dom: The runtime targeting the browser. Includes handling of native DOM API, attributes, properties, event handlers etc.

  • runtime-test: The lightweight runtime for testing. Can be used in any JavaScript environment since it "renders" a tree of plain JavaScript objects. The tree can be used to assert correct render output. Also provides utilities for serializing the tree, triggering events, and recording actual node operations performed during an update.

  • server-renderer: Package for server-side rendering.

  • compiler-core: The platform-agnostic compiler core. Includes the extensible base of the compiler and all platform-agnostic plugins.

  • compiler-dom: Compiler with additional plugins specifically targeting the browser.

  • template-explorer: A development tool for debugging compiler output. You can run yarn dev template-explorer and open its index.html to get a repl of template compilation based on current source code.

    A live version of the template explorer is also available, which can be used for providing reproductions for compiler bugs. You can also pick the deployment for a specific commit from the deploy logs.

  • shared: Private. Platform-agnostic internal utilities shared across multiple packages. This package is private and not published.

  • vue: The public facing "full build" which includes both the runtime AND the compiler.

Importing Packages

The packages can import each other directly using their package names. Note that when importing a package, the name listed in its package.json should be used. Most of the time the @vue/ prefix is needed:

import { h } from '@vue/runtime-core'

This is made possible via several configurations:

  • For TypeScript, compilerOptions.path in tsconfig.json
  • For Jest, moduleNameMapper in jest.config.js
  • For plain Node.js, they are linked using Yarn Workspaces.

Package Dependencies


                                    +---------------------+
                                    |                     |
                                    |  @vue/compiler-sfc  |
                                    |                     |
                                    +-----+--------+------+
                                          |        |
                                          v        v
                      +---------------------+    +----------------------+
                      |                     |    |                      |
        +------------>|  @vue/compiler-dom  +--->|  @vue/compiler-core  |
        |             |                     |    |                      |
   +----+----+        +---------------------+    +----------------------+
   |         |
   |   vue   |
   |         |
   +----+----+        +---------------------+    +----------------------+    +-------------------+
        |             |                     |    |                      |    |                   |
        +------------>|  @vue/runtime-dom   +--->|  @vue/runtime-core   +--->|  @vue/reactivity  |
                      |                     |    |                      |    |                   |
                      +---------------------+    +----------------------+    +-------------------+

There are some rules to follow when importing across package boundaries:

  • Never use direct relative paths when importing items from another package - export it in the source package and import it at the package level.

  • Compiler packages should not import items from the runtime, and vice versa. If something needs to be shared between the compiler-side and runtime-side, it should be extracted into @vue/shared instead.

  • If a package (A) has a non-type import from another package (B), package (B) should be listed as a dependency in the package.json of package (A). This is because the packages are externalized in the ESM-bundler/CJS builds and type declaration files, so the dependency packages must be actually installed as a dependency when consumed from package registries.

Contributing Tests

Unit tests are collocated with the code being tested in each package, inside directories named __tests__. Consult the Jest docs and existing test cases for how to write new test specs. Here are some additional guidelines:

  • Use the minimal API needed for a test case. For example, if a test can be written without involving the reactivity system or a component, it should be written so. This limits the test's exposure to changes in unrelated parts and makes it more stable.

  • If testing platform agnostic behavior or asserting low-level virtual DOM operations, use @vue/runtime-test.

  • Only use platform-specific runtimes if the test is asserting platform-specific behavior.

Testing Type Definition Correctness

This project uses tsd to test the built definition files (*.d.ts).

Type tests are located in the test-dts directory. To run the dts tests, run yarn test-dts. Note that the type test requires all relevant *.d.ts files to be built first (and the script does it for you). Once the d.ts files are built and up-to-date, the tests can be re-run by simply running ./node_modules/.bin/tsd.

Financial Contribution

As a pure community-driven project without major corporate backing, we also welcome financial contributions via Patreon and OpenCollective.

What's the difference between Patreon and OpenCollective funding?

Funds donated via Patreon go directly to support Evan You's full-time work on Vue.js. Funds donated via OpenCollective are managed with transparent expenses and will be used for compensating work and expenses for core team members or sponsoring community events. Your name/logo will receive proper recognition and exposure by donating on either platform.

Credits

Thank you to all the people who have already contributed to Vue.js!