refactor: tweak arguments

This commit is contained in:
Evan You 2018-10-15 12:41:18 -04:00
parent 24ff686848
commit b0f3a67e29
2 changed files with 6 additions and 11 deletions

View File

@ -23,12 +23,11 @@ import { handleError, ErrorTypes } from './errorHandling'
import { warn } from './warning'
let currentVNode: VNode | null = null
let currentContextVNode: MountedVNode | null = null
let currentContextVNode: VNode | null = null
export function createComponentInstance(
vnode: VNode,
Component: ComponentClass,
contextVNode: MountedVNode | null
Component: ComponentClass
): ComponentInstance {
// component instance creation is done in two steps.
// first, `initializeComponentInstance` is called inside base component
@ -38,7 +37,7 @@ export function createComponentInstance(
// we are storing the vnodes in variables here so that there's no need to
// always pass args in super()
currentVNode = vnode
currentContextVNode = contextVNode
currentContextVNode = vnode.contextVNode
const instance = (vnode.children = new Component() as ComponentInstance)
// then we finish the initialization by collecting properties set on the
// instance

View File

@ -210,9 +210,9 @@ export function createRenderer(options: RendererOptions) {
}
const { flags } = vnode
if (flags & VNodeFlags.COMPONENT_STATEFUL) {
mountStatefulComponent(vnode, container, contextVNode, isSVG, endNode)
mountStatefulComponent(vnode, container, isSVG, endNode)
} else {
mountFunctionalComponent(vnode, container, contextVNode, isSVG, endNode)
mountFunctionalComponent(vnode, container, isSVG, endNode)
}
if (__DEV__) {
popContext()
@ -222,7 +222,6 @@ export function createRenderer(options: RendererOptions) {
function mountStatefulComponent(
vnode: VNode,
container: RenderNode | null,
contextVNode: MountedVNode | null,
isSVG: boolean,
endNode: RenderNode | null
) {
@ -234,7 +233,6 @@ export function createRenderer(options: RendererOptions) {
vnode,
vnode.tag as ComponentClass,
container,
contextVNode,
isSVG,
endNode
)
@ -244,7 +242,6 @@ export function createRenderer(options: RendererOptions) {
function mountFunctionalComponent(
vnode: VNode,
container: RenderNode | null,
contextVNode: MountedVNode | null,
isSVG: boolean,
endNode: RenderNode | null
) {
@ -1156,7 +1153,6 @@ export function createRenderer(options: RendererOptions) {
vnode: VNode,
Component: ComponentClass,
container: RenderNode | null,
contextVNode: MountedVNode | null,
isSVG: boolean,
endNode: RenderNode | null
): RenderNode {
@ -1164,7 +1160,7 @@ export function createRenderer(options: RendererOptions) {
// new Vue()
const instance =
(__COMPAT__ && (vnode.children as ComponentInstance)) ||
createComponentInstance(vnode, Component, contextVNode)
createComponentInstance(vnode, Component)
// inject platform-specific unmount to keep-alive container
if ((Component as any)[KeepAliveSymbol] === true) {