perf: avoid deopt for props/emits normalization when global mixins are used
This commit is contained in:
parent
e2ca67b59a
commit
51d2be2038
@ -20,6 +20,8 @@ import { devtoolsInitApp, devtoolsUnmountApp } from './devtools'
|
||||
import { isFunction, NO, isObject } from '@vue/shared'
|
||||
import { version } from '.'
|
||||
import { installAppCompatProperties } from './compat/global'
|
||||
import { NormalizedPropsOptions } from './componentProps'
|
||||
import { ObjectEmitsOptions } from './componentEmits'
|
||||
|
||||
export interface App<HostElement = any> {
|
||||
version: string
|
||||
@ -101,13 +103,19 @@ export interface AppContext {
|
||||
* Cache for merged/normalized component options
|
||||
* Each app instance has its own cache because app-level global mixins and
|
||||
* optionMergeStrategies can affect merge behavior.
|
||||
*/
|
||||
cache: WeakMap<ComponentOptions, MergedComponentOptions>
|
||||
/**
|
||||
* Flag for de-optimizing props normalization
|
||||
* @internal
|
||||
*/
|
||||
deopt?: boolean
|
||||
optionsCache: WeakMap<ComponentOptions, MergedComponentOptions>
|
||||
/**
|
||||
* Cache for normalized props options
|
||||
* @internal
|
||||
*/
|
||||
propsCache: WeakMap<ConcreteComponent, NormalizedPropsOptions>
|
||||
/**
|
||||
* Cache for normalized emits options
|
||||
* @internal
|
||||
*/
|
||||
emitsCache: WeakMap<ConcreteComponent, ObjectEmitsOptions | null>
|
||||
/**
|
||||
* HMR only
|
||||
* @internal
|
||||
@ -144,7 +152,9 @@ export function createAppContext(): AppContext {
|
||||
components: {},
|
||||
directives: {},
|
||||
provides: Object.create(null),
|
||||
cache: new WeakMap()
|
||||
optionsCache: new WeakMap(),
|
||||
propsCache: new WeakMap(),
|
||||
emitsCache: new WeakMap()
|
||||
}
|
||||
}
|
||||
|
||||
@ -213,11 +223,6 @@ export function createAppAPI<HostElement>(
|
||||
if (__FEATURE_OPTIONS_API__) {
|
||||
if (!context.mixins.includes(mixin)) {
|
||||
context.mixins.push(mixin)
|
||||
// global mixin with props/emits de-optimizes props/emits
|
||||
// normalization caching.
|
||||
if (mixin.props || mixin.emits) {
|
||||
context.deopt = true
|
||||
}
|
||||
} else if (__DEV__) {
|
||||
warn(
|
||||
'Mixin has already been applied to target app' +
|
||||
|
@ -76,14 +76,6 @@ export interface AllowedComponentProps {
|
||||
// Note: can't mark this whole interface internal because some public interfaces
|
||||
// extend it.
|
||||
export interface ComponentInternalOptions {
|
||||
/**
|
||||
* @internal
|
||||
*/
|
||||
__props?: NormalizedPropsOptions
|
||||
/**
|
||||
* @internal
|
||||
*/
|
||||
__emits?: ObjectEmitsOptions | null
|
||||
/**
|
||||
* @internal
|
||||
*/
|
||||
|
@ -172,8 +172,10 @@ export function normalizeEmitsOptions(
|
||||
appContext: AppContext,
|
||||
asMixin = false
|
||||
): ObjectEmitsOptions | null {
|
||||
if (!appContext.deopt && comp.__emits !== undefined) {
|
||||
return comp.__emits
|
||||
const cache = appContext.emitsCache
|
||||
const cached = cache.get(comp)
|
||||
if (cached !== undefined) {
|
||||
return cached
|
||||
}
|
||||
|
||||
const raw = comp.emits
|
||||
@ -201,7 +203,8 @@ export function normalizeEmitsOptions(
|
||||
}
|
||||
|
||||
if (!raw && !hasExtends) {
|
||||
return (comp.__emits = null)
|
||||
cache.set(comp, null)
|
||||
return null
|
||||
}
|
||||
|
||||
if (isArray(raw)) {
|
||||
@ -209,7 +212,9 @@ export function normalizeEmitsOptions(
|
||||
} else {
|
||||
extend(normalized, raw)
|
||||
}
|
||||
return (comp.__emits = normalized)
|
||||
|
||||
cache.set(comp, normalized)
|
||||
return normalized
|
||||
}
|
||||
|
||||
// Check if an incoming prop key is a declared emit event listener.
|
||||
|
@ -894,7 +894,7 @@ export function resolveMergedOptions(
|
||||
const { mixins, extends: extendsOptions } = base
|
||||
const {
|
||||
mixins: globalMixins,
|
||||
cache,
|
||||
optionsCache: cache,
|
||||
config: { optionMergeStrategies }
|
||||
} = instance.appContext
|
||||
const cached = cache.get(base)
|
||||
|
@ -436,8 +436,10 @@ export function normalizePropsOptions(
|
||||
appContext: AppContext,
|
||||
asMixin = false
|
||||
): NormalizedPropsOptions {
|
||||
if (!appContext.deopt && comp.__props) {
|
||||
return comp.__props
|
||||
const cache = appContext.propsCache
|
||||
const cached = cache.get(comp)
|
||||
if (cached) {
|
||||
return cached
|
||||
}
|
||||
|
||||
const raw = comp.props
|
||||
@ -468,7 +470,8 @@ export function normalizePropsOptions(
|
||||
}
|
||||
|
||||
if (!raw && !hasExtends) {
|
||||
return (comp.__props = EMPTY_ARR as any)
|
||||
cache.set(comp, EMPTY_ARR as any)
|
||||
return EMPTY_ARR as any
|
||||
}
|
||||
|
||||
if (isArray(raw)) {
|
||||
@ -506,7 +509,9 @@ export function normalizePropsOptions(
|
||||
}
|
||||
}
|
||||
|
||||
return (comp.__props = [normalized, needCastKeys])
|
||||
const res: NormalizedPropsOptions = [normalized, needCastKeys]
|
||||
cache.set(comp, res)
|
||||
return res
|
||||
}
|
||||
|
||||
function validatePropName(key: string) {
|
||||
|
Loading…
Reference in New Issue
Block a user