vue3-yuanma/packages/runtime-core/__tests__/rendererAttrsFallthrough.spec.ts
Evan You e1660f4338 refactor(runtime-core): adjust attr fallthrough behavior
BREAKING CHANGE: adjust attr fallthrough behavior

    Updated per pending RFC https://github.com/vuejs/rfcs/pull/137

    - Implicit fallthrough now by default only applies for a whitelist
      of attributes (class, style, event listeners, a11y attributes, and
      data attributes).

    - Fallthrough is now applied regardless of whether the component has
      explicitly declared props. (close #749)
2020-02-28 17:53:26 -05:00

318 lines
7.8 KiB
TypeScript

// using DOM renderer because this case is mostly DOM-specific
import {
h,
render,
nextTick,
mergeProps,
ref,
onUpdated,
defineComponent,
openBlock,
createBlock
} from '@vue/runtime-dom'
import { mockWarn } from '@vue/shared'
describe('attribute fallthrough', () => {
mockWarn()
it('should allow whitelisted attrs to fallthrough', async () => {
const click = jest.fn()
const childUpdated = jest.fn()
const Hello = {
setup() {
const count = ref(0)
function inc() {
count.value++
click()
}
return () =>
h(Child, {
foo: 1,
id: 'test',
class: 'c' + count.value,
style: { color: count.value ? 'red' : 'green' },
onClick: inc,
'data-id': 1
})
}
}
const Child = {
setup(props: any) {
onUpdated(childUpdated)
return () =>
h(
'div',
{
id: props.id, // id is not whitelisted
class: 'c2',
style: { fontWeight: 'bold' }
},
props.foo
)
}
}
const root = document.createElement('div')
document.body.appendChild(root)
render(h(Hello), root)
const node = root.children[0] as HTMLElement
expect(node.getAttribute('id')).toBe('test') // id is not whitelisted, but explicitly bound
expect(node.getAttribute('foo')).toBe(null) // foo is not whitelisted
expect(node.getAttribute('class')).toBe('c2 c0')
expect(node.style.color).toBe('green')
expect(node.style.fontWeight).toBe('bold')
expect(node.dataset.id).toBe('1')
node.dispatchEvent(new CustomEvent('click'))
expect(click).toHaveBeenCalled()
await nextTick()
expect(childUpdated).toHaveBeenCalled()
expect(node.getAttribute('id')).toBe('test')
expect(node.getAttribute('foo')).toBe(null)
expect(node.getAttribute('class')).toBe('c2 c1')
expect(node.style.color).toBe('red')
expect(node.style.fontWeight).toBe('bold')
})
it('should fallthrough for nested components', async () => {
const click = jest.fn()
const childUpdated = jest.fn()
const grandChildUpdated = jest.fn()
const Hello = {
setup() {
const count = ref(0)
function inc() {
count.value++
click()
}
return () =>
h(Child, {
foo: 1,
id: 'test',
class: 'c' + count.value,
style: { color: count.value ? 'red' : 'green' },
onClick: inc
})
}
}
const Child = {
setup(props: any) {
onUpdated(childUpdated)
// HOC simply passing props down.
// this will result in merging the same attrs, but should be deduped by
// `mergeProps`.
return () => h(GrandChild, props)
}
}
const GrandChild = defineComponent({
props: {
id: String,
foo: Number
},
setup(props) {
onUpdated(grandChildUpdated)
return () =>
h(
'div',
{
id: props.id,
class: 'c2',
style: { fontWeight: 'bold' }
},
props.foo
)
}
})
const root = document.createElement('div')
document.body.appendChild(root)
render(h(Hello), root)
const node = root.children[0] as HTMLElement
// with declared props, any parent attr that isn't a prop falls through
expect(node.getAttribute('id')).toBe('test')
expect(node.getAttribute('class')).toBe('c2 c0')
expect(node.style.color).toBe('green')
expect(node.style.fontWeight).toBe('bold')
node.dispatchEvent(new CustomEvent('click'))
expect(click).toHaveBeenCalled()
// ...while declared ones remain props
expect(node.hasAttribute('foo')).toBe(false)
await nextTick()
expect(childUpdated).toHaveBeenCalled()
expect(grandChildUpdated).toHaveBeenCalled()
expect(node.getAttribute('id')).toBe('test')
expect(node.getAttribute('class')).toBe('c2 c1')
expect(node.style.color).toBe('red')
expect(node.style.fontWeight).toBe('bold')
expect(node.hasAttribute('foo')).toBe(false)
})
it('should not fallthrough with inheritAttrs: false', () => {
const Parent = {
render() {
return h(Child, { foo: 1, class: 'parent' })
}
}
const Child = defineComponent({
props: ['foo'],
inheritAttrs: false,
render() {
return h('div', this.foo)
}
})
const root = document.createElement('div')
document.body.appendChild(root)
render(h(Parent), root)
// should not contain class
expect(root.innerHTML).toMatch(`<div>1</div>`)
})
it('explicit spreading with inheritAttrs: false', () => {
const Parent = {
render() {
return h(Child, { foo: 1, class: 'parent' })
}
}
const Child = defineComponent({
props: ['foo'],
inheritAttrs: false,
render() {
return h(
'div',
mergeProps(
{
class: 'child'
},
this.$attrs
),
this.foo
)
}
})
const root = document.createElement('div')
document.body.appendChild(root)
render(h(Parent), root)
// should merge parent/child classes
expect(root.innerHTML).toMatch(`<div class="child parent">1</div>`)
})
it('should warn when fallthrough fails on non-single-root', () => {
const Parent = {
render() {
return h(Child, { foo: 1, class: 'parent' })
}
}
const Child = defineComponent({
props: ['foo'],
render() {
return [h('div'), h('div')]
}
})
const root = document.createElement('div')
document.body.appendChild(root)
render(h(Parent), root)
expect(`Extraneous non-props attributes (class)`).toHaveBeenWarned()
})
it('should not warn when $attrs is used during render', () => {
const Parent = {
render() {
return h(Child, { foo: 1, class: 'parent' })
}
}
const Child = defineComponent({
props: ['foo'],
render() {
return [h('div'), h('div', this.$attrs)]
}
})
const root = document.createElement('div')
document.body.appendChild(root)
render(h(Parent), root)
expect(`Extraneous non-props attributes`).not.toHaveBeenWarned()
expect(root.innerHTML).toBe(`<div></div><div class="parent"></div>`)
})
it('should not warn when context.attrs is used during render', () => {
const Parent = {
render() {
return h(Child, { foo: 1, class: 'parent' })
}
}
const Child = defineComponent({
props: ['foo'],
setup(_props, { attrs }) {
return () => [h('div'), h('div', attrs)]
}
})
const root = document.createElement('div')
document.body.appendChild(root)
render(h(Parent), root)
expect(`Extraneous non-props attributes`).not.toHaveBeenWarned()
expect(root.innerHTML).toBe(`<div></div><div class="parent"></div>`)
})
// #677
it('should update merged dynamic attrs on optimized child root', async () => {
const aria = ref('true')
const cls = ref('bar')
const Parent = {
render() {
return h(Child, { 'aria-hidden': aria.value, class: cls.value })
}
}
const Child = {
props: [],
render() {
return openBlock(), createBlock('div')
}
}
const root = document.createElement('div')
document.body.appendChild(root)
render(h(Parent), root)
expect(root.innerHTML).toBe(`<div aria-hidden="true" class="bar"></div>`)
aria.value = 'false'
await nextTick()
expect(root.innerHTML).toBe(`<div aria-hidden="false" class="bar"></div>`)
cls.value = 'barr'
await nextTick()
expect(root.innerHTML).toBe(`<div aria-hidden="false" class="barr"></div>`)
})
})