fix(reactivity): avoid triggering effect when deleting property returns false (#168)

2019-10-09 23:55:57 +08:00 · 2019-10-09 23:55:57 +08:00 · ff68db46ea
commit ff68db46ea
parent b9a4d8d088
1 changed files with 1 additions and 1 deletions
--- a/packages/reactivity/src/baseHandlers.ts
+++ b/packages/reactivity/src/baseHandlers.ts
@ -70,7 +70,7 @@ function deleteProperty(target: any, key: string | symbol): boolean {
  const hadKey = hasOwn(target, key)
  const oldValue = target[key]
  const result = Reflect.deleteProperty(target, key)
-  if (hadKey) {
+  if (result && hadKey) {
    /* istanbul ignore else */
    if (__DEV__) {
      trigger(target, OperationTypes.DELETE, key, { oldValue })