theluyuan/vue3-yuanma
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(reactivity): avoid triggering effect when deleting property returns false (#168)

Browse Source
This commit is contained in:
terencez 2019-10-09 23:55:57 +08:00 committed by Evan You
parent b9a4d8d088
commit ff68db46ea
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/reactivity/src/baseHandlers.ts
View File

@ -70,7 +70,7 @@ function deleteProperty(target: any, key: string | symbol): boolean {
const hadKey = hasOwn(target, key) const hadKey = hasOwn(target, key)
const oldValue = target[key] const oldValue = target[key]
const result = Reflect.deleteProperty(target, key) const result = Reflect.deleteProperty(target, key)
if (hadKey) { if (result && hadKey) {
/* istanbul ignore else */ /* istanbul ignore else */
if (__DEV__) { if (__DEV__) {
trigger(target, OperationTypes.DELETE, key, { oldValue }) trigger(target, OperationTypes.DELETE, key, { oldValue })