From fc5aa6d0be9886e7bdda013469fba219da1080c9 Mon Sep 17 00:00:00 2001 From: Evan You Date: Mon, 12 Nov 2018 22:42:34 -0500 Subject: [PATCH] feat: proper static tree skip --- packages/runtime-core/src/createRenderer.ts | 13 ++++++++++++- packages/runtime-core/src/vdom.ts | 9 +++++++-- 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/packages/runtime-core/src/createRenderer.ts b/packages/runtime-core/src/createRenderer.ts index 09b7c9cb..a789c3c1 100644 --- a/packages/runtime-core/src/createRenderer.ts +++ b/packages/runtime-core/src/createRenderer.ts @@ -477,7 +477,18 @@ export function createRenderer(options: RendererOptions) { contextVNode: MountedVNode | null, isSVG: boolean ) { - const { flags, tag } = nextVNode + const { flags, tag, clonedFrom } = nextVNode + + // cloned vnodes pointing to the same original. + // these are hoisted static trees so just skip entirely + if ( + clonedFrom !== null && + (clonedFrom === prevVNode || clonedFrom === prevVNode.clonedFrom) + ) { + nextVNode.el = prevVNode.el + return + } + isSVG = isSVG || (flags & VNodeFlags.ELEMENT_SVG) > 0 if (prevVNode.tag !== tag) { diff --git a/packages/runtime-core/src/vdom.ts b/packages/runtime-core/src/vdom.ts index be222b67..b44d2c1d 100644 --- a/packages/runtime-core/src/vdom.ts +++ b/packages/runtime-core/src/vdom.ts @@ -43,6 +43,8 @@ export interface VNode { // a consistent handle so that a functional component can be identified // by the scheduler handle: FunctionalHandle | null + // only on cloned vnodes, points to the original cloned vnode + clonedFrom: VNode | null } export interface MountedVNode extends VNode { @@ -99,7 +101,8 @@ export function createVNode( el: null, parentVNode: null, contextVNode: null, - handle: null + handle: null, + clonedFrom: null } if (childFlags === ChildrenFlags.UNKNOWN_CHILDREN) { normalizeChildren(vnode, children) @@ -339,7 +342,7 @@ export function cloneVNode(vnode: VNode, extraData?: VNodeData): VNode { } } } - return createVNode( + const cloned = createVNode( flags, vnode.tag, clonedData, @@ -349,6 +352,8 @@ export function cloneVNode(vnode: VNode, extraData?: VNodeData): VNode { vnode.ref, vnode.slots ) + cloned.clonedFrom = vnode.clonedFrom || vnode + return cloned } else if (flags & VNodeFlags.TEXT) { return createTextVNode(vnode.children as string) } else {