From fb8e83f0c2d690bcda970cf05971cbfba0cad796 Mon Sep 17 00:00:00 2001 From: Evan You Date: Tue, 21 Jul 2020 10:24:51 -0400 Subject: [PATCH] chore: update link for the feature flag warning [ci skip] --- packages/runtime-core/src/featureFlags.ts | 8 +++----- packages/vue/README.md | 2 ++ 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/runtime-core/src/featureFlags.ts b/packages/runtime-core/src/featureFlags.ts index 8ddf56c8..ee2f1368 100644 --- a/packages/runtime-core/src/featureFlags.ts +++ b/packages/runtime-core/src/featureFlags.ts @@ -23,11 +23,9 @@ export function initFeatureFlags() { if (__DEV__ && needWarn) { console.warn( `You are running the esm-bundler build of Vue. It is recommended to ` + - `configure your bundler to explicitly replace the following global ` + - `variables with boolean literals so that it can remove unnecessary code:\n\n` + - `- __VUE_OPTIONS_API__ (support for Options API, default: true)\n` + - `- __VUE_PROD_DEVTOOLS__ (enable devtools inspection in production, default: false)` - // TODO link to docs + `configure your bundler to explicitly replace feature flag globals ` + + `with boolean literals to get proper tree-shaking in the final bundle. ` + + `See http://link.vuejs.org/feature-flags for more details.` ) } } diff --git a/packages/vue/README.md b/packages/vue/README.md index be977691..be9932dc 100644 --- a/packages/vue/README.md +++ b/packages/vue/README.md @@ -44,6 +44,8 @@ - Rollup: use [@rollup/plugin-replace](https://github.com/rollup/plugins/tree/master/packages/replace) - Vite: configured by default, but can be overwritten using the [`define` option](https://github.com/vitejs/vite/blob/a4133c073e640b17276b2de6e91a6857bdf382e1/src/node/config.ts#L72-L76) + Note: the replacement value **must be boolean literals** and cannot be strings, otherwise the bundler/minifier will not be able to properly evaluate the conditions. + ### For Server-Side Rendering - **`vue.cjs(.prod).js`**: