theluyuan/vue3-yuanma
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(runtime-dom): attribute should be removed with nullish values (#2679)

Browse Source 
fix #2677
This commit is contained in:
edison
2020-12-01 08:28:03 +08:00
committed by GitHub
parent 64d4681e4b
commit fb6b9f8e8f
2 changed files with 21 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
packages/runtime-dom/__tests__/patchProps.spec.ts
View File

@@ -120,6 +120,23 @@ describe('runtime-dom: props patching', () => {
patchProp(el, 'id', null, '')
expect(el.hasAttribute('id')).toBe(true)
// #2677
const img = document.createElement('img')
patchProp(img, 'width', null, '')
expect(el.hasAttribute('width')).toBe(false)
patchProp(img, 'width', null, 0)
expect(img.hasAttribute('width')).toBe(true)
patchProp(img, 'width', null, null)
expect(img.hasAttribute('width')).toBe(false)
patchProp(img, 'width', null, 0)
expect(img.hasAttribute('width')).toBe(true)
patchProp(img, 'width', null, undefined)
expect(img.hasAttribute('width')).toBe(false)
patchProp(img, 'width', null, 0)
expect(img.hasAttribute('width')).toBe(true)
})
test('form attribute', () => {