theluyuan/vue3-yuanma
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor(reactivity): simplify if condition (#1002)

Browse Source
This commit is contained in:
limichange 2020-04-21 01:39:35 +08:00 committed by GitHub
parent 6390093691
commit fa40d1ef3a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
packages/reactivity/src/effect.ts
View File

@ -141,11 +141,11 @@ export function track(target: object, type: TrackOpTypes, key: unknown) {
return return
} }
let depsMap = targetMap.get(target) let depsMap = targetMap.get(target)
if (depsMap === void 0) { if (!depsMap) {
targetMap.set(target, (depsMap = new Map())) targetMap.set(target, (depsMap = new Map()))
} }
let dep = depsMap.get(key) let dep = depsMap.get(key)
if (dep === void 0) { if (!dep) {
depsMap.set(key, (dep = new Set())) depsMap.set(key, (dep = new Set()))
} }
if (!dep.has(activeEffect)) { if (!dep.has(activeEffect)) {
@ -171,7 +171,7 @@ export function trigger(
oldTarget?: Map<unknown, unknown> | Set<unknown> oldTarget?: Map<unknown, unknown> | Set<unknown>
) { ) {
const depsMap = targetMap.get(target) const depsMap = targetMap.get(target)
if (depsMap === void 0) { if (!depsMap) {
// never been tracked // never been tracked
return return
} }
@ -179,7 +179,7 @@ export function trigger(
const effects = new Set<ReactiveEffect>() const effects = new Set<ReactiveEffect>()
const computedRunners = new Set<ReactiveEffect>() const computedRunners = new Set<ReactiveEffect>()
const add = (effectsToAdd: Set<ReactiveEffect> | undefined) => { const add = (effectsToAdd: Set<ReactiveEffect> | undefined) => {
if (effectsToAdd !== void 0) { if (effectsToAdd) {
effectsToAdd.forEach(effect => { effectsToAdd.forEach(effect => {
if (effect !== activeEffect || !shouldTrack) { if (effect !== activeEffect || !shouldTrack) {
if (effect.options.computed) { if (effect.options.computed) {
@ -238,7 +238,7 @@ export function trigger(
oldTarget oldTarget
}) })
} }
if (effect.options.scheduler !== void 0) { if (effect.options.scheduler) {
effect.options.scheduler(effect) effect.options.scheduler(effect)
} else { } else {
effect() effect()