fix(compiler): bail strigification on runtime constant expressions

This commit is contained in:
Evan You
2020-05-04 15:15:26 -04:00
parent 3c3fe88c64
commit f9a3766fd6
5 changed files with 80 additions and 3 deletions

View File

@@ -1,4 +1,9 @@
import { compile, NodeTypes, CREATE_STATIC } from '../../src'
import {
compile,
NodeTypes,
CREATE_STATIC,
createSimpleExpression
} from '../../src'
import {
stringifyStatic,
StringifyThresholds
@@ -121,4 +126,46 @@ describe('stringify static html', () => {
]
})
})
test('should bail on runtime constant v-bind bindings', () => {
const { ast } = compile(
`<div><div><img src="./foo" />${repeat(
`<span class="foo">foo</span>`,
StringifyThresholds.ELEMENT_WITH_BINDING_COUNT
)}</div></div>`,
{
hoistStatic: true,
prefixIdentifiers: true,
transformHoist: stringifyStatic,
nodeTransforms: [
node => {
if (node.type === NodeTypes.ELEMENT && node.tag === 'img') {
const exp = createSimpleExpression(
'_imports_0_',
false,
node.loc,
true
)
exp.isRuntimeConstant = true
node.props[0] = {
type: NodeTypes.DIRECTIVE,
name: 'bind',
arg: createSimpleExpression('src', true),
exp,
modifiers: [],
loc: node.loc
}
}
}
]
}
)
// the expression and the tree are still hoistable
expect(ast.hoists.length).toBe(1)
// ...but the hoisted tree should not be stringified
expect(ast.hoists[0]).toMatchObject({
// if it's stringified it will be NodeTypes.CALL_EXPRESSION
type: NodeTypes.VNODE_CALL
})
})
})