fix(compiler-core/v-on): fix codegen for event handler with newlines (#1640)
This commit is contained in:
parent
fa5ddf8d06
commit
f9826fa963
@ -271,6 +271,56 @@ describe('compiler: transform v-on', () => {
|
||||
})
|
||||
})
|
||||
|
||||
test('should NOT wrap as function if expression is already function expression (with newlines)', () => {
|
||||
const { node } = parseWithVOn(
|
||||
`<div @click="
|
||||
$event => {
|
||||
foo($event)
|
||||
}
|
||||
"/>`
|
||||
)
|
||||
expect((node.codegenNode as VNodeCall).props).toMatchObject({
|
||||
properties: [
|
||||
{
|
||||
key: { content: `onClick` },
|
||||
value: {
|
||||
type: NodeTypes.SIMPLE_EXPRESSION,
|
||||
content: `
|
||||
$event => {
|
||||
foo($event)
|
||||
}
|
||||
`
|
||||
}
|
||||
}
|
||||
]
|
||||
})
|
||||
})
|
||||
|
||||
test('should NOT wrap as function if expression is already function expression (with newlines + function keyword)', () => {
|
||||
const { node } = parseWithVOn(
|
||||
`<div @click="
|
||||
function($event) {
|
||||
foo($event)
|
||||
}
|
||||
"/>`
|
||||
)
|
||||
expect((node.codegenNode as VNodeCall).props).toMatchObject({
|
||||
properties: [
|
||||
{
|
||||
key: { content: `onClick` },
|
||||
value: {
|
||||
type: NodeTypes.SIMPLE_EXPRESSION,
|
||||
content: `
|
||||
function($event) {
|
||||
foo($event)
|
||||
}
|
||||
`
|
||||
}
|
||||
}
|
||||
]
|
||||
})
|
||||
})
|
||||
|
||||
test('should NOT wrap as function if expression is complex member expression', () => {
|
||||
const { node } = parseWithVOn(`<div @click="a['b' + c]"/>`)
|
||||
expect((node.codegenNode as VNodeCall).props).toMatchObject({
|
||||
|
@ -16,7 +16,7 @@ import { validateBrowserExpression } from '../validateExpression'
|
||||
import { isMemberExpression, hasScopeRef } from '../utils'
|
||||
import { CAPITALIZE } from '../runtimeHelpers'
|
||||
|
||||
const fnExpRE = /^([\w$_]+|\([^)]*?\))\s*=>|^function(?:\s+[\w$]+)?\s*\(/
|
||||
const fnExpRE = /^\s*([\w$_]+|\([^)]*?\))\s*=>|^\s*function(?:\s+[\w$]+)?\s*\(/
|
||||
|
||||
export interface VOnDirectiveNode extends DirectiveNode {
|
||||
// v-on without arg is handled directly in ./transformElements.ts due to it affecting
|
||||
|
Loading…
Reference in New Issue
Block a user