From f3623e4d1ea83d552b5ab29955dead6c36a87723 Mon Sep 17 00:00:00 2001 From: Evan You Date: Thu, 11 Jun 2020 11:44:39 -0400 Subject: [PATCH] fix(compiler-core): fix prod whitespace/comment removal fix #1256 --- packages/compiler-core/src/parse.ts | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/packages/compiler-core/src/parse.ts b/packages/compiler-core/src/parse.ts index f8153046..57a15925 100644 --- a/packages/compiler-core/src/parse.ts +++ b/packages/compiler-core/src/parse.ts @@ -216,13 +216,17 @@ function parseChildren( removedWhitespace = true nodes[i] = null as any } else { - // Otherwise, condensed consecutive whitespace inside the text down to - // a single space + // Otherwise, condensed consecutive whitespace inside the text + // down to a single space node.content = ' ' } } else { node.content = node.content.replace(/[\t\r\n\f ]+/g, ' ') } + } else if (!__DEV__ && node.type === NodeTypes.COMMENT) { + // remove comment nodes in prod + removedWhitespace = true + nodes[i] = null as any } } } else if (parent && context.options.isPreTag(parent.tag)) { @@ -239,12 +243,6 @@ function parseChildren( } function pushNode(nodes: TemplateChildNode[], node: TemplateChildNode): void { - // ignore comments in production - /* istanbul ignore next */ - if (!__DEV__ && node.type === NodeTypes.COMMENT) { - return - } - if (node.type === NodeTypes.TEXT) { const prev = last(nodes) // Merge if both this and the previous node are text and those are