theluyuan/vue3-yuanma
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(runtime-dom): patch textContent on svg properly (#4301)

Browse Source 
fix #4296
This commit is contained in:
edison 2021-08-11 22:53:54 +08:00 committed by GitHub
parent 1ce34e25d5
commit e7b0a9d3cf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
packages/runtime-dom/__tests__/patchAttrs.spec.ts
View File

@ -10,6 +10,13 @@ describe('runtime-dom: attrs patching', () => {
expect(el.getAttributeNS(xlinkNS, 'href')).toBe(null) expect(el.getAttributeNS(xlinkNS, 'href')).toBe(null)
}) })
test('textContent attributes /w svg', () => {
const el = document.createElementNS('http://www.w3.org/2000/svg', 'use')
patchProp(el, 'textContent', null, 'foo', true)
expect(el.attributes.length).toBe(0)
expect(el.innerHTML).toBe('foo')
})
test('boolean attributes', () => { test('boolean attributes', () => {
const el = document.createElement('input') const el = document.createElement('input')
patchProp(el, 'readonly', null, true) patchProp(el, 'readonly', null, true)

4
packages/runtime-dom/src/patchProp.ts
View File

@ -68,8 +68,8 @@ function shouldSetAsProp(
) { ) {
if (isSVG) { if (isSVG) {
// most keys must be set as attribute on svg elements to work // most keys must be set as attribute on svg elements to work
// ...except innerHTML // ...except innerHTML & textContent
if (key === 'innerHTML') { if (key === 'innerHTML' || key === 'textContent') {
return true return true
} }
// or native onclick with function values // or native onclick with function values