fix(types): ref value type unwrapping should happen at creation time

This commit is contained in:
Evan You 2020-02-25 19:44:06 -05:00
parent 711d16cc65
commit d4c6957e2d
4 changed files with 21 additions and 5 deletions

View File

@ -1,10 +1,10 @@
import { effect, ReactiveEffect, trigger, track } from './effect'
import { TriggerOpTypes, TrackOpTypes } from './operations'
import { Ref, UnwrapRef } from './ref'
import { Ref } from './ref'
import { isFunction, NOOP } from '@vue/shared'
export interface ComputedRef<T = any> extends WritableComputedRef<T> {
readonly value: UnwrapRef<T>
readonly value: T
}
export interface WritableComputedRef<T> extends Ref<T> {

View File

@ -17,7 +17,7 @@ export interface Ref<T = any> {
// don't want this internal field to leak into userland autocompletion -
// a private symbol, on the other hand, achieves just that.
[isRefSymbol]: true
value: UnwrapRef<T>
value: T
}
const convert = <T extends unknown>(val: T): T =>
@ -28,13 +28,13 @@ export function isRef(r: any): r is Ref {
return r ? r._isRef === true : false
}
export function ref<T>(value: T): T extends Ref ? T : Ref<T>
export function ref<T>(value: T): T extends Ref ? T : Ref<UnwrapRef<T>>
export function ref<T = any>(): Ref<T>
export function ref(value?: unknown) {
return createRef(value)
}
export function shallowRef<T>(value: T): T extends Ref ? T : Ref<T>
export function shallowRef<T>(value: T): T extends Ref ? T : Ref<UnwrapRef<T>>
export function shallowRef<T = any>(): Ref<T>
export function shallowRef(value?: unknown) {
return createRef(value, true)

View File

@ -13,6 +13,12 @@ function foo(arg: number | Ref<number>) {
// ref unwrapping
expectType<number>(unref(arg))
// ref inner type should be unwrapped
const nestedRef = ref({
foo: ref(1)
})
expectType<Ref<{ foo: number }>>(nestedRef)
}
foo(1)

View File

@ -52,3 +52,13 @@ watch(
},
{ immediate: true }
)
// should provide correct ref.value inner type to callbacks
const nestedRefSource = ref({
foo: ref(1)
})
watch(nestedRefSource, (v, ov) => {
expectType<{ foo: number }>(v)
expectType<{ foo: number }>(ov)
})