feat(runtime-core): improve warning for extraneous event listeners (#1005)

fix #1001
This commit is contained in:
Andrew Talbot
2020-04-20 16:40:59 -04:00
committed by GitHub
parent dece6102aa
commit cebad64d22
3 changed files with 119 additions and 20 deletions

View File

@@ -337,7 +337,7 @@ describe('attribute fallthrough', () => {
it('should warn when fallthrough fails on non-single-root', () => {
const Parent = {
render() {
return h(Child, { foo: 1, class: 'parent' })
return h(Child, { foo: 1, class: 'parent', onBar: () => {} })
}
}
@@ -353,12 +353,13 @@ describe('attribute fallthrough', () => {
render(h(Parent), root)
expect(`Extraneous non-props attributes (class)`).toHaveBeenWarned()
expect(`Extraneous non-emits event listeners`).toHaveBeenWarned()
})
it('should not warn when $attrs is used during render', () => {
const Parent = {
render() {
return h(Child, { foo: 1, class: 'parent' })
return h(Child, { foo: 1, class: 'parent', onBar: () => {} })
}
}
@@ -374,13 +375,15 @@ describe('attribute fallthrough', () => {
render(h(Parent), root)
expect(`Extraneous non-props attributes`).not.toHaveBeenWarned()
expect(`Extraneous non-emits event listeners`).not.toHaveBeenWarned()
expect(root.innerHTML).toBe(`<div></div><div class="parent"></div>`)
})
it('should not warn when context.attrs is used during render', () => {
const Parent = {
render() {
return h(Child, { foo: 1, class: 'parent' })
return h(Child, { foo: 1, class: 'parent', onBar: () => {} })
}
}
@@ -396,9 +399,72 @@ describe('attribute fallthrough', () => {
render(h(Parent), root)
expect(`Extraneous non-props attributes`).not.toHaveBeenWarned()
expect(`Extraneous non-emits event listeners`).not.toHaveBeenWarned()
expect(root.innerHTML).toBe(`<div></div><div class="parent"></div>`)
})
it('should not warn when context.attrs is used during render (functional)', () => {
const Parent = {
render() {
return h(Child, { foo: 1, class: 'parent', onBar: () => {} })
}
}
const Child: FunctionalComponent = (_, { attrs }) => [
h('div'),
h('div', attrs)
]
Child.props = ['foo']
const root = document.createElement('div')
document.body.appendChild(root)
render(h(Parent), root)
expect(`Extraneous non-props attributes`).not.toHaveBeenWarned()
expect(`Extraneous non-emits event listeners`).not.toHaveBeenWarned()
expect(root.innerHTML).toBe(`<div></div><div class="parent"></div>`)
})
it('should not warn when functional component has optional props', () => {
const Parent = {
render() {
return h(Child, { foo: 1, class: 'parent', onBar: () => {} })
}
}
const Child = (props: any) => [h('div'), h('div', { class: props.class })]
const root = document.createElement('div')
document.body.appendChild(root)
render(h(Parent), root)
expect(`Extraneous non-props attributes`).not.toHaveBeenWarned()
expect(`Extraneous non-emits event listeners`).not.toHaveBeenWarned()
expect(root.innerHTML).toBe(`<div></div><div class="parent"></div>`)
})
it('should warn when functional component has props and does not use attrs', () => {
const Parent = {
render() {
return h(Child, { foo: 1, class: 'parent', onBar: () => {} })
}
}
const Child: FunctionalComponent = () => [h('div'), h('div')]
Child.props = ['foo']
const root = document.createElement('div')
document.body.appendChild(root)
render(h(Parent), root)
expect(`Extraneous non-props attributes`).toHaveBeenWarned()
expect(`Extraneous non-emits event listeners`).toHaveBeenWarned()
expect(root.innerHTML).toBe(`<div></div><div></div>`)
})
// #677
it('should update merged dynamic attrs on optimized child root', async () => {
const aria = ref('true')