fix(transition): ensure manual style manipulation in transition leave hooks work

ref #2720
This commit is contained in:
Evan You
2020-12-03 16:10:22 -05:00
parent 3016b811b8
commit cbaa380506
4 changed files with 137 additions and 146 deletions

View File

@@ -143,33 +143,23 @@ export function resolveTransitionProps(
return extend(baseProps, {
onBeforeEnter(el) {
onBeforeEnter && onBeforeEnter(el)
addTransitionClass(el, enterActiveClass)
addTransitionClass(el, enterFromClass)
addTransitionClass(el, enterActiveClass)
},
onBeforeAppear(el) {
onBeforeAppear && onBeforeAppear(el)
addTransitionClass(el, appearActiveClass)
addTransitionClass(el, appearFromClass)
addTransitionClass(el, appearActiveClass)
},
onEnter: makeEnterHook(false),
onAppear: makeEnterHook(true),
onLeave(el, done) {
const resolve = () => finishLeave(el, done)
addTransitionClass(el, leaveActiveClass)
addTransitionClass(el, leaveFromClass)
const cachedTransition = (el as HTMLElement).style.transitionProperty
requestAnimationFrame(() => {
// ref #2531, #2593
// disabling the transition before nextFrame ensures styles from
// *-leave-from classes are applied instantly before the transition starts.
// ref #2712
// do this in an rAF to ensure styles from *-leave-active can trigger
// transition on the first frame when el has `transition` property itself.
;(el as HTMLElement).style.transitionProperty = 'none'
})
// force reflow so *-leave-from classes immediately take effect (#2593)
forceReflow()
addTransitionClass(el, leaveActiveClass)
nextFrame(() => {
;(el as HTMLElement).style.transitionProperty = cachedTransition
removeTransitionClass(el, leaveFromClass)
addTransitionClass(el, leaveToClass)
if (!(onLeave && onLeave.length > 1)) {
@@ -370,3 +360,8 @@ function getTimeout(delays: string[], durations: string[]): number {
function toMs(s: string): number {
return Number(s.slice(0, -1).replace(',', '.')) * 1000
}
// synchronously force layout to put elements into a certain state
export function forceReflow() {
return document.body.offsetHeight
}

View File

@@ -5,7 +5,8 @@ import {
ElementWithTransition,
getTransitionInfo,
resolveTransitionProps,
TransitionPropsValidators
TransitionPropsValidators,
forceReflow
} from './Transition'
import {
Fragment,
@@ -172,11 +173,6 @@ function applyTranslation(c: VNode): VNode | undefined {
}
}
// this is put in a dedicated function to avoid the line from being treeshaken
function forceReflow() {
return document.body.offsetHeight
}
function hasCSSTransform(
el: ElementWithTransition,
root: Node,