theluyuan/vue3-yuanma
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: move writable check out of computed setter (#112)

Browse Source
This commit is contained in:
扩散性百万甜面包 2019-10-06 03:48:05 +08:00 committed by Evan You
parent 0bdee72e17
commit caa9297da6
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
packages/reactivity/src/computed.ts
View File

@ -28,7 +28,9 @@ export function computed<T>(
? (getterOrOptions as (() => T)) ? (getterOrOptions as (() => T))
: (getterOrOptions as WritableComputedOptions<T>).get : (getterOrOptions as WritableComputedOptions<T>).get
const setter = isReadonly const setter = isReadonly
? null ? () => {
// TODO warn attempting to mutate readonly computed value
}
: (getterOrOptions as WritableComputedOptions<T>).set : (getterOrOptions as WritableComputedOptions<T>).set
let dirty: boolean = true let dirty: boolean = true
@ -57,12 +59,8 @@ export function computed<T>(
trackChildRun(runner) trackChildRun(runner)
return value return value
}, },
set value(newValue) { set value(newValue: T) {
if (setter) { setter(newValue)
setter(newValue)
} else {
// TODO warn attempting to mutate readonly computed value
}
} }
} }
} }