fix(compiler-dom): stringifyStatic should remove attribute bindings with null
value (#3477)
fix #3475
This commit is contained in:
parent
7cf143dd4f
commit
ca6aa01181
@ -294,4 +294,26 @@ describe('stringify static html', () => {
|
|||||||
})
|
})
|
||||||
})
|
})
|
||||||
})
|
})
|
||||||
|
|
||||||
|
test('should remove attribute for `null`', () => {
|
||||||
|
const { ast } = compileWithStringify(
|
||||||
|
`<div>${repeat(
|
||||||
|
`<span :title="null"></span>`,
|
||||||
|
StringifyThresholds.ELEMENT_WITH_BINDING_COUNT
|
||||||
|
)}</div>`
|
||||||
|
)
|
||||||
|
expect(ast.hoists[0]).toMatchObject({
|
||||||
|
type: NodeTypes.JS_CALL_EXPRESSION,
|
||||||
|
callee: CREATE_STATIC,
|
||||||
|
arguments: [
|
||||||
|
JSON.stringify(
|
||||||
|
`${repeat(
|
||||||
|
`<span></span>`,
|
||||||
|
StringifyThresholds.ELEMENT_WITH_BINDING_COUNT
|
||||||
|
)}`
|
||||||
|
),
|
||||||
|
'5'
|
||||||
|
]
|
||||||
|
})
|
||||||
|
})
|
||||||
})
|
})
|
||||||
|
@ -264,15 +264,17 @@ function stringifyElement(
|
|||||||
} else if (p.type === NodeTypes.DIRECTIVE && p.name === 'bind') {
|
} else if (p.type === NodeTypes.DIRECTIVE && p.name === 'bind') {
|
||||||
// constant v-bind, e.g. :foo="1"
|
// constant v-bind, e.g. :foo="1"
|
||||||
let evaluated = evaluateConstant(p.exp as SimpleExpressionNode)
|
let evaluated = evaluateConstant(p.exp as SimpleExpressionNode)
|
||||||
const arg = p.arg && (p.arg as SimpleExpressionNode).content
|
if (evaluated != null) {
|
||||||
if (arg === 'class') {
|
const arg = p.arg && (p.arg as SimpleExpressionNode).content
|
||||||
evaluated = normalizeClass(evaluated)
|
if (arg === 'class') {
|
||||||
} else if (arg === 'style') {
|
evaluated = normalizeClass(evaluated)
|
||||||
evaluated = stringifyStyle(normalizeStyle(evaluated))
|
} else if (arg === 'style') {
|
||||||
|
evaluated = stringifyStyle(normalizeStyle(evaluated))
|
||||||
|
}
|
||||||
|
res += ` ${(p.arg as SimpleExpressionNode).content}="${escapeHtml(
|
||||||
|
evaluated
|
||||||
|
)}"`
|
||||||
}
|
}
|
||||||
res += ` ${(p.arg as SimpleExpressionNode).content}="${escapeHtml(
|
|
||||||
evaluated
|
|
||||||
)}"`
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
if (context.scopeId) {
|
if (context.scopeId) {
|
||||||
|
Loading…
Reference in New Issue
Block a user