theluyuan/vue3-yuanma
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

feat: warn duplicate plugin installations

Browse Source
This commit is contained in:
Evan You 2019-11-05 10:49:00 -05:00
parent 2d5f9b58ac
commit c61e5463fa
2 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/runtime-core/__tests__/apiApp.spec.ts
View File

@ -259,6 +259,11 @@ describe('api: createApp', () => {
const root = nodeOps.createElement('div') const root = nodeOps.createElement('div')
app.mount(Root, root) app.mount(Root, root)
expect(serializeInner(root)).toBe(`1,2`) expect(serializeInner(root)).toBe(`1,2`)
app.use(PluginA)
expect(
`Plugin has already been applied to target app`
).toHaveBeenWarnedTimes(1)
}) })
test('config.errorHandler', () => { test('config.errorHandler', () => {

7
packages/runtime-core/src/apiApp.ts
View File

@ -79,6 +79,7 @@ export function createAppAPI<HostNode, HostElement>(
): () => App<HostElement> { ): () => App<HostElement> {
return function createApp(): App { return function createApp(): App {
const context = createAppContext() const context = createAppContext()
const installedPlugins = new Set()
let isMounted = false let isMounted = false
@ -96,9 +97,13 @@ export function createAppAPI<HostNode, HostElement>(
}, },
use(plugin: Plugin) { use(plugin: Plugin) {
if (isFunction(plugin)) { if (installedPlugins.has(plugin)) {
__DEV__ && warn(`Plugin has already been applied to target app.`)
} else if (isFunction(plugin)) {
installedPlugins.add(plugin)
plugin(app) plugin(app)
} else if (isFunction(plugin.install)) { } else if (isFunction(plugin.install)) {
installedPlugins.add(plugin)
plugin.install(app) plugin.install(app)
} else if (__DEV__) { } else if (__DEV__) {
warn( warn(