fix(runtime-dom): ensure readonly type prop on textarea is handled patched as attribute (#2888)

close #2766

Co-authored-by: Thorsten Luenborg <t.luneborg@googlemail.com>
This commit is contained in:
Thorsten Lünborg 2021-02-24 20:51:19 +01:00 committed by GitHub
parent 4117def226
commit c5d147c57f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 0 deletions

View File

@ -149,4 +149,11 @@ describe('runtime-dom: props patching', () => {
patchProp(el, 'form', 'foo', null)
expect(el.getAttribute('form')).toBe(null)
})
test('readonly type prop on textarea', () => {
const el = document.createElement('textarea')
// just to verify that it doesn't throw when i.e. switching a dynamic :is from an 'input' to a 'textarea'
// see https://github.com/vuejs/vue-next/issues/2766
patchProp(el, 'type', 'text', null)
})
})

View File

@ -115,5 +115,10 @@ function shouldSetAsProp(
return false
}
// DOMprop "type" is readonly on textarea elements: https://github.com/vuejs/vue-next/issues/2766
if (key === 'type' && el.tagName === 'TEXTAREA') {
return false
}
return key in el
}