theluyuan/vue3-yuanma
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test: test the right branches of code

Browse Source
This commit is contained in:
Evan You 2019-09-24 22:56:57 -04:00
parent 642a44f8f0
commit af585081b1
3 changed files with 16 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/compiler-core/__tests__/transforms/vBind.spec.ts
View File

@ -87,7 +87,7 @@ describe('compiler: transform v-bind', () => {
test('should error if no expression', () => { test('should error if no expression', () => {
const onError = jest.fn() const onError = jest.fn()
parseWithVBind(`<div v-bind />`, { onError }) parseWithVBind(`<div v-bind:arg />`, { onError })
expect(onError.mock.calls[0][0]).toMatchObject({ expect(onError.mock.calls[0][0]).toMatchObject({
code: ErrorCodes.X_V_BIND_NO_EXPRESSION, code: ErrorCodes.X_V_BIND_NO_EXPRESSION,
loc: { loc: {
@ -97,7 +97,7 @@ describe('compiler: transform v-bind', () => {
}, },
end: { end: {
line: 1, line: 1,
column: 12 column: 16
} }
} }
}) })

12
packages/compiler-core/__tests__/transforms/vOn.spec.ts
View File

@ -103,9 +103,9 @@ describe('compiler: transform v-bind', () => {
}) })
}) })
test('should error if no expression', () => { test('should error if no expression AND no modifier', () => {
const onError = jest.fn() const onError = jest.fn()
parseWithVOn(`<div v-on />`, { onError }) parseWithVOn(`<div v-on:click />`, { onError })
expect(onError.mock.calls[0][0]).toMatchObject({ expect(onError.mock.calls[0][0]).toMatchObject({
code: ErrorCodes.X_V_ON_NO_EXPRESSION, code: ErrorCodes.X_V_ON_NO_EXPRESSION,
loc: { loc: {
@ -115,11 +115,17 @@ describe('compiler: transform v-bind', () => {
}, },
end: { end: {
line: 1, line: 1,
column: 10 column: 16
} }
} }
}) })
}) })
test('should NOT error if no expression but has modifier', () => {
const onError = jest.fn()
parseWithVOn(`<div v-on:click.prevent />`, { onError })
expect(onError).not.toHaveBeenCalled()
})
test.todo('.once modifier') test.todo('.once modifier')
}) })

7
packages/compiler-core/src/transforms/vOn.ts
View File

@ -7,8 +7,11 @@ import { isSimpleIdentifier } from '../utils'
// v-on without arg is handled directly in ./element.ts due to it affecting // v-on without arg is handled directly in ./element.ts due to it affecting
// codegen for the entire props object. This transform here is only for v-on // codegen for the entire props object. This transform here is only for v-on
// *with* args. // *with* args.
export const transformOn: DirectiveTransform = ({ arg, exp, loc }, context) => { export const transformOn: DirectiveTransform = (
if (!exp) { { arg, exp, loc, modifiers },
context
) => {
if (!exp && !modifiers.length) {
context.onError(createCompilerError(ErrorCodes.X_V_ON_NO_EXPRESSION, loc)) context.onError(createCompilerError(ErrorCodes.X_V_ON_NO_EXPRESSION, loc))
} }
const { content, children, isStatic, loc: argLoc } = arg! const { content, children, isStatic, loc: argLoc } = arg!