fix(runtime-dom): event handlers with modifiers should get all event arguments (#1193)
This commit is contained in:
parent
d73a508a73
commit
ab86b190ce
@ -118,4 +118,13 @@ describe('runtime-dom: v-on directive', () => {
|
|||||||
expect(fn).toBeCalled()
|
expect(fn).toBeCalled()
|
||||||
})
|
})
|
||||||
})
|
})
|
||||||
|
|
||||||
|
it('should handle multiple arguments when using modifiers', () => {
|
||||||
|
const el = document.createElement('div')
|
||||||
|
const fn = jest.fn()
|
||||||
|
const handler = withModifiers(fn, ['ctrl'])
|
||||||
|
const event = triggerEvent(el, 'click', e => (e.ctrlKey = true))
|
||||||
|
handler(event, 'value', true)
|
||||||
|
expect(fn).toBeCalledWith(event, 'value', true)
|
||||||
|
})
|
||||||
})
|
})
|
||||||
|
@ -26,12 +26,12 @@ const modifierGuards: Record<
|
|||||||
* @internal
|
* @internal
|
||||||
*/
|
*/
|
||||||
export const withModifiers = (fn: Function, modifiers: string[]) => {
|
export const withModifiers = (fn: Function, modifiers: string[]) => {
|
||||||
return (event: Event) => {
|
return (event: Event, ...args: unknown[]) => {
|
||||||
for (let i = 0; i < modifiers.length; i++) {
|
for (let i = 0; i < modifiers.length; i++) {
|
||||||
const guard = modifierGuards[modifiers[i]]
|
const guard = modifierGuards[modifiers[i]]
|
||||||
if (guard && guard(event, modifiers)) return
|
if (guard && guard(event, modifiers)) return
|
||||||
}
|
}
|
||||||
return fn(event)
|
return fn(event, ...args)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user