fix(reactivity): should not trigger length dependency on Array delete

close #774
2020-03-06 11:30:56 -05:00
parent 689d45fb3d
commit a3066581f3
2 changed files with 12 additions and 1 deletions
--- a/packages/reactivity/tests/reactiveArray.spec.ts
+++ b/packages/reactivity/tests/reactiveArray.spec.ts
@@ -88,6 +88,17 @@ describe('reactivity/reactive/Array', () => {
    expect(index).toBe(1)
  })

+  test('delete on Array should not trigger length dependency', () => {
+    const arr = reactive([1, 2, 3])
+    const fn = jest.fn()
+    effect(() => {
+      fn(arr.length)
+    })
+    expect(fn).toHaveBeenCalledTimes(1)
+    delete arr[1]
+    expect(fn).toHaveBeenCalledTimes(1)
+  })
+
  describe('Array methods w/ refs', () => {
    let original: any[]
    beforeEach(() => {