theluyuan/vue3-yuanma
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(runtime-dom): fix static content re-insertion

Browse Source 
fix #5308

The regression was introduced in ed9eb62. In the cached code path,
we attempt re-insertion by cloning cached nodes. However if the static
fragment was removed as component root, it loses the nodes between
start and end because each node was removed individually. Therefore
the cached path can only be taken if the fragment has a single node, or
it was removed as part of a parent tree so the sibling information is
still available.
This commit is contained in:
Evan You 2022-01-23 21:37:54 +08:00
parent 4be1037f31
commit 9aa5dfd4bb
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/runtime-dom/src/nodeOps.ts
View File

@ -76,7 +76,10 @@ export const nodeOps: Omit<RendererOptions<Node, Element>, 'patchProp'> = {
insertStaticContent(content, parent, anchor, isSVG, start, end) { insertStaticContent(content, parent, anchor, isSVG, start, end) {
// <parent> before | first ... last | anchor </parent> // <parent> before | first ... last | anchor </parent>
const before = anchor ? anchor.previousSibling : parent.lastChild const before = anchor ? anchor.previousSibling : parent.lastChild
if (start && end) { // #5308 can only take cached path if:
// - has a single root node
// - nextSibling info is still available
if (start && (start === end || start.nextSibling)) {
// cached // cached
while (true) { while (true) {
parent.insertBefore(start!.cloneNode(true), anchor) parent.insertBefore(start!.cloneNode(true), anchor)