fix(runtime-dom): fix option element value patching edge case (#4959)

fix #4956
2021-11-25 11:05:02 +01:00
parent 3c449cd408
commit 89b2f924fc
2 changed files with 10 additions and 1 deletions
--- a/packages/runtime-dom/src/modules/props.ts
+++ b/packages/runtime-dom/src/modules/props.ts
@@ -31,7 +31,13 @@ export function patchDOMProp(
    // non-string values will be stringified.
    el._value = value
    const newValue = value == null ? '' : value
-    if (el.value !== newValue) {
+    if (
+      el.value !== newValue ||
+      // #4956: always set for OPTION elements because its value falls back to
+      // textContent if no value attribute is present. And setting .value for
+      // OPTION has no side effect
+      el.tagName === 'OPTION'
+    ) {
      el.value = newValue
    }
    if (value == null) {