fix(runtime-dom): fix option element value patching edge case (#4959)

fix #4956
2021-11-25 11:05:02 +01:00
parent 3c449cd408
commit 89b2f924fc
2 changed files with 10 additions and 1 deletions
--- a/packages/runtime-dom/tests/patchProps.spec.ts
+++ b/packages/runtime-dom/tests/patchProps.spec.ts
@@ -29,9 +29,12 @@ describe('runtime-dom: props patching', () => {
  // so we need to add tests for other elements
  test('value for non-text input', () => {
    const el = document.createElement('option')
+    el.textContent = 'foo' // #4956
    patchProp(el, 'value', null, 'foo')
+    expect(el.getAttribute('value')).toBe('foo')
    expect(el.value).toBe('foo')
    patchProp(el, 'value', null, null)
+    el.textContent = ''
    expect(el.value).toBe('')
    // #3475
    expect(el.getAttribute('value')).toBe(null)