refactor: rename things

This commit is contained in:
Evan You
2018-11-13 11:03:35 -05:00
parent 0cd8183fbf
commit 80d1eb7480
22 changed files with 423 additions and 414 deletions

View File

@@ -1,4 +1,4 @@
import { observable, autorun, unwrap, isObservable } from '../../src'
import { observable, effect, unwrap, isObservable } from '../../src'
describe('observer/collections', () => {
describe('Map', () => {
@@ -13,7 +13,7 @@ describe('observer/collections', () => {
it('should observe mutations', () => {
let dummy
const map = observable(new Map())
autorun(() => {
effect(() => {
dummy = map.get('key')
})
@@ -29,7 +29,7 @@ describe('observer/collections', () => {
it('should observe size mutations', () => {
let dummy
const map = observable(new Map())
autorun(() => (dummy = map.size))
effect(() => (dummy = map.size))
expect(dummy).toBe(0)
map.set('key1', 'value')
@@ -44,7 +44,7 @@ describe('observer/collections', () => {
it('should observe for of iteration', () => {
let dummy
const map = observable(new Map())
autorun(() => {
effect(() => {
dummy = 0
// eslint-disable-next-line no-unused-vars
for (let [key, num] of map) {
@@ -67,7 +67,7 @@ describe('observer/collections', () => {
it('should observe forEach iteration', () => {
let dummy: any
const map = observable(new Map())
autorun(() => {
effect(() => {
dummy = 0
map.forEach((num: any) => (dummy += num))
})
@@ -86,7 +86,7 @@ describe('observer/collections', () => {
it('should observe keys iteration', () => {
let dummy
const map = observable(new Map())
autorun(() => {
effect(() => {
dummy = 0
for (let key of map.keys()) {
dummy += key
@@ -107,7 +107,7 @@ describe('observer/collections', () => {
it('should observe values iteration', () => {
let dummy
const map = observable(new Map())
autorun(() => {
effect(() => {
dummy = 0
for (let num of map.values()) {
dummy += num
@@ -128,7 +128,7 @@ describe('observer/collections', () => {
it('should observe entries iteration', () => {
let dummy
const map = observable(new Map())
autorun(() => {
effect(() => {
dummy = 0
// eslint-disable-next-line no-unused-vars
for (let [key, num] of map.entries()) {
@@ -151,7 +151,7 @@ describe('observer/collections', () => {
it('should be triggered by clearing', () => {
let dummy
const map = observable(new Map())
autorun(() => (dummy = map.get('key')))
effect(() => (dummy = map.get('key')))
expect(dummy).toBe(undefined)
map.set('key', 3)
@@ -163,7 +163,7 @@ describe('observer/collections', () => {
it('should not observe custom property mutations', () => {
let dummy
const map: any = observable(new Map())
autorun(() => (dummy = map.customProp))
effect(() => (dummy = map.customProp))
expect(dummy).toBe(undefined)
map.customProp = 'Hello World'
@@ -174,7 +174,7 @@ describe('observer/collections', () => {
let dummy
const map = observable(new Map())
const mapSpy = jest.fn(() => (dummy = map.get('key')))
autorun(mapSpy)
effect(mapSpy)
expect(dummy).toBe(undefined)
expect(mapSpy).toHaveBeenCalledTimes(1)
@@ -198,7 +198,7 @@ describe('observer/collections', () => {
it('should not observe raw data', () => {
let dummy
const map = observable(new Map())
autorun(() => (dummy = unwrap(map).get('key')))
effect(() => (dummy = unwrap(map).get('key')))
expect(dummy).toBe(undefined)
map.set('key', 'Hello')
@@ -229,7 +229,7 @@ describe('observer/collections', () => {
const observed = observable(new Map())
observed.set('key', { a: 1 })
let dummy
autorun(() => {
effect(() => {
dummy = observed.get('key').a
})
observed.get('key').a = 2
@@ -239,7 +239,7 @@ describe('observer/collections', () => {
it('should observe nested values in iterations (forEach)', () => {
const map = observable(new Map([[1, { foo: 1 }]]))
let dummy: any
autorun(() => {
effect(() => {
dummy = 0
map.forEach(value => {
expect(isObservable(value)).toBe(true)
@@ -254,7 +254,7 @@ describe('observer/collections', () => {
it('should observe nested values in iterations (values)', () => {
const map = observable(new Map([[1, { foo: 1 }]]))
let dummy: any
autorun(() => {
effect(() => {
dummy = 0
for (const value of map.values()) {
expect(isObservable(value)).toBe(true)
@@ -270,7 +270,7 @@ describe('observer/collections', () => {
const key = {}
const map = observable(new Map([[key, { foo: 1 }]]))
let dummy: any
autorun(() => {
effect(() => {
dummy = 0
for (const [key, value] of map.entries()) {
key
@@ -288,7 +288,7 @@ describe('observer/collections', () => {
const key = {}
const map = observable(new Map([[key, { foo: 1 }]]))
let dummy: any
autorun(() => {
effect(() => {
dummy = 0
for (const [key, value] of map) {
key

View File

@@ -1,4 +1,4 @@
import { observable, autorun, isObservable, unwrap } from '../../src'
import { observable, effect, isObservable, unwrap } from '../../src'
describe('observer/collections', () => {
describe('Set', () => {
@@ -13,7 +13,7 @@ describe('observer/collections', () => {
it('should observe mutations', () => {
let dummy
const set = observable(new Set())
autorun(() => (dummy = set.has('value')))
effect(() => (dummy = set.has('value')))
expect(dummy).toBe(false)
set.add('value')
@@ -25,7 +25,7 @@ describe('observer/collections', () => {
it('should observe for of iteration', () => {
let dummy
const set = observable(new Set())
autorun(() => {
effect(() => {
dummy = 0
for (let num of set) {
dummy += num
@@ -45,7 +45,7 @@ describe('observer/collections', () => {
it('should observe forEach iteration', () => {
let dummy: any
const set = observable(new Set())
autorun(() => {
effect(() => {
dummy = 0
set.forEach(num => (dummy += num))
})
@@ -63,7 +63,7 @@ describe('observer/collections', () => {
it('should observe values iteration', () => {
let dummy
const set = observable(new Set())
autorun(() => {
effect(() => {
dummy = 0
for (let num of set.values()) {
dummy += num
@@ -83,7 +83,7 @@ describe('observer/collections', () => {
it('should observe keys iteration', () => {
let dummy
const set = observable(new Set())
autorun(() => {
effect(() => {
dummy = 0
for (let num of set.keys()) {
dummy += num
@@ -103,7 +103,7 @@ describe('observer/collections', () => {
it('should observe entries iteration', () => {
let dummy
const set = observable(new Set())
autorun(() => {
effect(() => {
dummy = 0
// eslint-disable-next-line no-unused-vars
for (let [key, num] of set.entries()) {
@@ -125,7 +125,7 @@ describe('observer/collections', () => {
it('should be triggered by clearing', () => {
let dummy
const set = observable(new Set())
autorun(() => (dummy = set.has('key')))
effect(() => (dummy = set.has('key')))
expect(dummy).toBe(false)
set.add('key')
@@ -137,7 +137,7 @@ describe('observer/collections', () => {
it('should not observe custom property mutations', () => {
let dummy
const set: any = observable(new Set())
autorun(() => (dummy = set.customProp))
effect(() => (dummy = set.customProp))
expect(dummy).toBe(undefined)
set.customProp = 'Hello World'
@@ -147,7 +147,7 @@ describe('observer/collections', () => {
it('should observe size mutations', () => {
let dummy
const set = observable(new Set())
autorun(() => (dummy = set.size))
effect(() => (dummy = set.size))
expect(dummy).toBe(0)
set.add('value')
@@ -163,7 +163,7 @@ describe('observer/collections', () => {
let dummy
const set = observable(new Set())
const setSpy = jest.fn(() => (dummy = set.has('value')))
autorun(setSpy)
effect(setSpy)
expect(dummy).toBe(false)
expect(setSpy).toHaveBeenCalledTimes(1)
@@ -187,7 +187,7 @@ describe('observer/collections', () => {
it('should not observe raw data', () => {
let dummy
const set = observable(new Set())
autorun(() => (dummy = unwrap(set).has('value')))
effect(() => (dummy = unwrap(set).has('value')))
expect(dummy).toBe(false)
set.add('value')
@@ -197,7 +197,7 @@ describe('observer/collections', () => {
it('should not observe raw iterations', () => {
let dummy = 0
const set = observable(new Set())
autorun(() => {
effect(() => {
dummy = 0
for (let [num] of unwrap(set).entries()) {
dummy += num
@@ -227,7 +227,7 @@ describe('observer/collections', () => {
it('should not be triggered by raw mutations', () => {
let dummy
const set = observable(new Set())
autorun(() => (dummy = set.has('value')))
effect(() => (dummy = set.has('value')))
expect(dummy).toBe(false)
unwrap(set).add('value')
@@ -242,7 +242,7 @@ describe('observer/collections', () => {
it('should not observe raw size mutations', () => {
let dummy
const set = observable(new Set())
autorun(() => (dummy = unwrap(set).size))
effect(() => (dummy = unwrap(set).size))
expect(dummy).toBe(0)
set.add('value')
@@ -252,7 +252,7 @@ describe('observer/collections', () => {
it('should not be triggered by raw size mutations', () => {
let dummy
const set = observable(new Set())
autorun(() => (dummy = set.size))
effect(() => (dummy = set.size))
expect(dummy).toBe(0)
unwrap(set).add('value')
@@ -264,7 +264,7 @@ describe('observer/collections', () => {
const key = {}
const set = observable(new Set())
const setSpy = jest.fn(() => (dummy = set.has(key)))
autorun(setSpy)
effect(setSpy)
expect(dummy).toBe(false)
expect(setSpy).toHaveBeenCalledTimes(1)
@@ -290,7 +290,7 @@ describe('observer/collections', () => {
it('should observe nested values in iterations (forEach)', () => {
const set = observable(new Set([{ foo: 1 }]))
let dummy: any
autorun(() => {
effect(() => {
dummy = 0
set.forEach(value => {
expect(isObservable(value)).toBe(true)
@@ -307,7 +307,7 @@ describe('observer/collections', () => {
it('should observe nested values in iterations (values)', () => {
const set = observable(new Set([{ foo: 1 }]))
let dummy: any
autorun(() => {
effect(() => {
dummy = 0
for (const value of set.values()) {
expect(isObservable(value)).toBe(true)
@@ -324,7 +324,7 @@ describe('observer/collections', () => {
it('should observe nested values in iterations (entries)', () => {
const set = observable(new Set([{ foo: 1 }]))
let dummy: any
autorun(() => {
effect(() => {
dummy = 0
for (const [key, value] of set.entries()) {
expect(isObservable(key)).toBe(true)
@@ -342,7 +342,7 @@ describe('observer/collections', () => {
it('should observe nested values in iterations (for...of)', () => {
const set = observable(new Set([{ foo: 1 }]))
let dummy: any
autorun(() => {
effect(() => {
dummy = 0
for (const value of set) {
expect(isObservable(value)).toBe(true)

View File

@@ -1,4 +1,4 @@
import { observable, autorun, unwrap, isObservable } from '../../src'
import { observable, effect, unwrap, isObservable } from '../../src'
describe('observer/collections', () => {
describe('WeakMap', () => {
@@ -14,7 +14,7 @@ describe('observer/collections', () => {
let dummy
const key = {}
const map = observable(new WeakMap())
autorun(() => {
effect(() => {
dummy = map.get(key)
})
@@ -30,7 +30,7 @@ describe('observer/collections', () => {
it('should not observe custom property mutations', () => {
let dummy
const map: any = observable(new WeakMap())
autorun(() => (dummy = map.customProp))
effect(() => (dummy = map.customProp))
expect(dummy).toBe(undefined)
map.customProp = 'Hello World'
@@ -42,7 +42,7 @@ describe('observer/collections', () => {
const key = {}
const map = observable(new WeakMap())
const mapSpy = jest.fn(() => (dummy = map.get(key)))
autorun(mapSpy)
effect(mapSpy)
expect(dummy).toBe(undefined)
expect(mapSpy).toHaveBeenCalledTimes(1)
@@ -64,7 +64,7 @@ describe('observer/collections', () => {
let dummy
const key = {}
const map = observable(new WeakMap())
autorun(() => (dummy = unwrap(map).get(key)))
effect(() => (dummy = unwrap(map).get(key)))
expect(dummy).toBe(undefined)
map.set(key, 'Hello')
@@ -98,7 +98,7 @@ describe('observer/collections', () => {
const key = {}
observed.set(key, { a: 1 })
let dummy
autorun(() => {
effect(() => {
dummy = observed.get(key).a
})
observed.get(key).a = 2

View File

@@ -1,4 +1,4 @@
import { observable, isObservable, autorun, unwrap } from '../../src'
import { observable, isObservable, effect, unwrap } from '../../src'
describe('observer/collections', () => {
describe('WeakSet', () => {
@@ -14,7 +14,7 @@ describe('observer/collections', () => {
let dummy
const value = {}
const set = observable(new WeakSet())
autorun(() => (dummy = set.has(value)))
effect(() => (dummy = set.has(value)))
expect(dummy).toBe(false)
set.add(value)
@@ -26,7 +26,7 @@ describe('observer/collections', () => {
it('should not observe custom property mutations', () => {
let dummy
const set: any = observable(new WeakSet())
autorun(() => (dummy = set.customProp))
effect(() => (dummy = set.customProp))
expect(dummy).toBe(undefined)
set.customProp = 'Hello World'
@@ -38,7 +38,7 @@ describe('observer/collections', () => {
const value = {}
const set = observable(new WeakSet())
const setSpy = jest.fn(() => (dummy = set.has(value)))
autorun(setSpy)
effect(setSpy)
expect(dummy).toBe(false)
expect(setSpy).toHaveBeenCalledTimes(1)
@@ -60,7 +60,7 @@ describe('observer/collections', () => {
const value = {}
let dummy
const set = observable(new WeakSet())
autorun(() => (dummy = unwrap(set).has(value)))
effect(() => (dummy = unwrap(set).has(value)))
expect(dummy).toBe(false)
set.add(value)
@@ -71,7 +71,7 @@ describe('observer/collections', () => {
const value = {}
let dummy
const set = observable(new WeakSet())
autorun(() => (dummy = set.has(value)))
effect(() => (dummy = set.has(value)))
expect(dummy).toBe(false)
unwrap(set).add(value)