theluyuan/vue3-yuanma
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: todos

Browse Source
This commit is contained in:
Evan You 2019-09-09 16:03:34 -04:00
parent 02bb156314
commit 7e70acf9c2
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/runtime-core/src/createRenderer.ts
View File

@ -623,7 +623,7 @@ export function createRenderer<
) )
if (suspense.deps > 0) { if (suspense.deps > 0) {
// still pending. // still pending.
// patch the fallback tree. // TODO patch the fallback tree.
} else { } else {
suspense.resolve() suspense.resolve()
} }
@ -677,9 +677,7 @@ export function createRenderer<
) )
// now check if we have encountered any async deps // now check if we have encountered any async deps
if (suspense.deps > 0) { if (suspense.deps > 0) {
// yes: mount the fallback tree. // TODO mount the fallback tree.
// Each time an async dep resolves, it pings the boundary
// and causes a re-entry.
console.log('fallback') console.log('fallback')
} else { } else {
suspense.resolve() suspense.resolve()
@ -742,6 +740,7 @@ export function createRenderer<
setupRenderEffect(instance, n2, container, anchor, isSVG) setupRenderEffect(instance, n2, container, anchor, isSVG)
} else if ( } else if (
shouldUpdateComponent(n1, n2, optimized) || shouldUpdateComponent(n1, n2, optimized) ||
// TODO use context suspense
(instance.provides.suspense && (instance.provides.suspense &&
!(instance.provides.suspense as any).isResolved) !(instance.provides.suspense as any).isResolved)
) { ) {
@ -793,6 +792,7 @@ export function createRenderer<
// setup() is async. This component relies on async logic to be resolved // setup() is async. This component relies on async logic to be resolved
// before proceeding // before proceeding
if (instance.asyncDep) { if (instance.asyncDep) {
// TODO use context suspense
const suspense = (instance as any).provides.suspense const suspense = (instance as any).provides.suspense
if (!suspense) { if (!suspense) {
throw new Error('Async component without a suspense boundary!') throw new Error('Async component without a suspense boundary!')