theluyuan/vue3-yuanma
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(compiler-core/v-on): pass noninitial arguments in cached event handlers (#1265)

Browse Source
This commit is contained in:
Cathrine Vaage 2020-06-15 21:04:03 +02:00 committed by GitHub
parent 35dbef268c
commit 7e28173312
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 18 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/compiler-core/__tests__/transforms/__snapshots__/hoistStatic.spec.ts.snap
View File

@ -209,7 +209,7 @@ export function render(_ctx, _cache) {
return (_openBlock(), _createBlock(\\"div\\", null, [ return (_openBlock(), _createBlock(\\"div\\", null, [
_createVNode(\\"div\\", null, [ _createVNode(\\"div\\", null, [
_createVNode(\\"div\\", { _createVNode(\\"div\\", {
onClick: _cache[1] || (_cache[1] = $event => (_ctx.foo($event))) onClick: _cache[1] || (_cache[1] = ($event, ...args) => (_ctx.foo($event, ...args)))
}) })
]) ])
])) ]))

20
packages/compiler-core/__tests__/transforms/vOn.spec.ts
View File

@ -142,7 +142,7 @@ describe('compiler: transform v-on', () => {
key: { content: `onClick` }, key: { content: `onClick` },
value: { value: {
type: NodeTypes.COMPOUND_EXPRESSION, type: NodeTypes.COMPOUND_EXPRESSION,
children: [`$event => (`, { content: `i++` }, `)`] children: [`($event, ...args) => (`, { content: `i++` }, `)`]
} }
} }
] ]
@ -160,7 +160,11 @@ describe('compiler: transform v-on', () => {
// should wrap with `{` for multiple statements // should wrap with `{` for multiple statements
// in this case the return value is discarded and the behavior is // in this case the return value is discarded and the behavior is
// consistent with 2.x // consistent with 2.x
children: [`$event => {`, { content: `foo();bar()` }, `}`] children: [
`($event, ...args) => {`,
{ content: `foo();bar()` },
`}`
]
} }
} }
] ]
@ -196,7 +200,7 @@ describe('compiler: transform v-on', () => {
value: { value: {
type: NodeTypes.COMPOUND_EXPRESSION, type: NodeTypes.COMPOUND_EXPRESSION,
children: [ children: [
`$event => (`, `($event, ...args) => (`,
{ {
type: NodeTypes.COMPOUND_EXPRESSION, type: NodeTypes.COMPOUND_EXPRESSION,
children: [ children: [
@ -226,7 +230,7 @@ describe('compiler: transform v-on', () => {
value: { value: {
type: NodeTypes.COMPOUND_EXPRESSION, type: NodeTypes.COMPOUND_EXPRESSION,
children: [ children: [
`$event => {`, `($event, ...args) => {`,
{ {
children: [ children: [
{ content: `_ctx.foo` }, { content: `_ctx.foo` },
@ -400,7 +404,11 @@ describe('compiler: transform v-on', () => {
index: 1, index: 1,
value: { value: {
type: NodeTypes.COMPOUND_EXPRESSION, type: NodeTypes.COMPOUND_EXPRESSION,
children: [`$event => (`, { content: `_ctx.foo($event)` }, `)`] children: [
`($event, ...args) => (`,
{ content: `_ctx.foo($event, ...args)` },
`)`
]
} }
}) })
}) })
@ -444,7 +452,7 @@ describe('compiler: transform v-on', () => {
value: { value: {
type: NodeTypes.COMPOUND_EXPRESSION, type: NodeTypes.COMPOUND_EXPRESSION,
children: [ children: [
`$event => (`, `($event, ...args) => (`,
{ children: [{ content: `_ctx.foo` }, `++`] }, { children: [{ content: `_ctx.foo` }, `++`] },
`)` `)`
] ]

6
packages/compiler-core/src/transforms/vOn.ts
View File

@ -83,9 +83,9 @@ export const transformOn: DirectiveTransform = (
// avoiding the need to be patched. // avoiding the need to be patched.
if (isCacheable && isMemberExp) { if (isCacheable && isMemberExp) {
if (exp.type === NodeTypes.SIMPLE_EXPRESSION) { if (exp.type === NodeTypes.SIMPLE_EXPRESSION) {
exp.content += `($event)` exp.content += `($event, ...args)`
} else { } else {
exp.children.push(`($event)`) exp.children.push(`($event, ...args)`)
} }
} }
} }
@ -102,7 +102,7 @@ export const transformOn: DirectiveTransform = (
if (isInlineStatement || (isCacheable && isMemberExp)) { if (isInlineStatement || (isCacheable && isMemberExp)) {
// wrap inline statement in a function expression // wrap inline statement in a function expression
exp = createCompoundExpression([ exp = createCompoundExpression([
`$event => ${hasMultipleStatements ? `{` : `(`}`, `($event, ...args) => ${hasMultipleStatements ? `{` : `(`}`,
exp, exp,
hasMultipleStatements ? `}` : `)` hasMultipleStatements ? `}` : `)`
]) ])