theluyuan/vue3-yuanma
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(compiler-core): dynamic component should always be made blocks

Browse Source 
since it can potentially resolve to plain elements

fix #1018
This commit is contained in:
Evan You 2020-04-22 14:44:45 -04:00
parent 0bdd889156
commit 7d0ab3392a
1 changed files with 20 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
packages/compiler-core/src/transforms/transformElement.ts
View File

@ -20,7 +20,13 @@ import {
DirectiveArguments,
createVNodeCall
} from '../ast'
import { PatchFlags, PatchFlagNames, isSymbol, isOn } from '@vue/shared'
import {
PatchFlags,
PatchFlagNames,
isSymbol,
isOn,
isObject
} from '@vue/shared'
import { createCompilerError, ErrorCodes } from '../errors'
import {
RESOLVE_DIRECTIVE,
@ -68,6 +74,8 @@ export const transformElement: NodeTransform = (node, context) => {
const vnodeTag = isComponent
? resolveComponentType(node as ComponentNode, context)
: `"${tag}"`
const isDynamicComponent =
isObject(vnodeTag) && vnodeTag.callee === RESOLVE_DYNAMIC_COMPONENT
let vnodeProps: VNodeCall['props']
let vnodeChildren: VNodeCall['children']
@ -78,15 +86,17 @@ export const transformElement: NodeTransform = (node, context) => {
let vnodeDirectives: VNodeCall['directives']
let shouldUseBlock =
!isComponent &&
// <svg> and <foreignObject> must be forced into blocks so that block
// updates inside get proper isSVG flag at runtime. (#639, #643)
// This is technically web-specific, but splitting the logic out of core
// leads to too much unnecessary complexity.
(tag === 'svg' ||
tag === 'foreignObject' ||
// #938: elements with dynamic keys should be forced into blocks
findProp(node, 'key', true))
// dynamic component may resolve to plain elements
isDynamicComponent ||
(!isComponent &&
// <svg> and <foreignObject> must be forced into blocks so that block
// updates inside get proper isSVG flag at runtime. (#639, #643)
// This is technically web-specific, but splitting the logic out of core
// leads to too much unnecessary complexity.
(tag === 'svg' ||
tag === 'foreignObject' ||
// #938: elements with dynamic keys should be forced into blocks
findProp(node, 'key', true)))
// props
if (props.length > 0) {