wip: generate codeframe for compiler deprecations

packages/compiler-core/src/compat/compatConfig.ts

@@ -124,13 +124,8 @@ export function warnDeprecation(
     typeof message === 'function' ? message(...args) : message
   }${link ? `\n  Details: ${link}` : ``}`
 
-  if (loc) {
   const err = new SyntaxError(msg) as CompilerError
   err.code = key
-    err.loc = loc
+  if (loc) err.loc = loc
   context.onWarn(err)
-    return
-  }
-
-  context.onWarn(msg)
 }

packages/compiler-core/src/options.ts

@@ -10,7 +10,7 @@ import { CompilerCompatOptions } from './compat/compatConfig'
 import { ParserPlugin } from '@babel/parser'
 
 export interface ErrorHandlingOptions {
-  onWarn?: (msg: string | CompilerError) => void
+  onWarn?: (warning: CompilerError) => void
   onError?: (error: CompilerError) => void
 }
 

packages/vue-compat/src/index.ts

@@ -1,7 +1,7 @@
 // This entry is the "full-build" that includes both the runtime
 // and the compiler, and supports on-the-fly compilation of the template option.
 import { initDev } from './dev'
-import { compile, CompilerOptions, CompilerError } from '@vue/compiler-dom'
+import { compile, CompilerError, CompilerOptions } from '@vue/compiler-dom'
 import {
   registerRuntimeCompiler,
   RenderFunction,
@@ -55,8 +55,21 @@ function compileToFunction(
     extend(
       {
         hoistStatic: true,
-        onError(err: CompilerError) {
+        onError(err) {
           if (__DEV__) {
+            onError(err)
+          } else {
+            /* istanbul ignore next */
+            throw err
+          }
+        },
+        onWarn: __DEV__ ? onError : NOOP
+      } as CompilerOptions,
+      options
+    )
+  )
+
+  function onError(err: CompilerError) {
     const message = `Template compilation error: ${err.message}`
     const codeFrame =
       err.loc &&
@@ -66,15 +79,7 @@ function compileToFunction(
         err.loc.end.offset
       )
     warn(codeFrame ? `${message}\n${codeFrame}` : message)
-          } else {
-            /* istanbul ignore next */
-            throw err
   }
-        }
-      },
-      options
-    )
-  )
 
   // The wildcard import results in a huge object with every export
   // with keys that cannot be mangled, and can be quite heavy size-wise.

packages/vue/src/index.ts

@@ -49,8 +49,21 @@ function compileToFunction(
     extend(
       {
         hoistStatic: true,
-        onError(err: CompilerError) {
+        onError(err) {
           if (__DEV__) {
+            onError(err)
+          } else {
+            /* istanbul ignore next */
+            throw err
+          }
+        },
+        onWarn: __DEV__ ? onError : NOOP
+      } as CompilerOptions,
+      options
+    )
+  )
+
+  function onError(err: CompilerError) {
     const message = `Template compilation error: ${err.message}`
     const codeFrame =
       err.loc &&
@@ -60,15 +73,7 @@ function compileToFunction(
         err.loc.end.offset
       )
     warn(codeFrame ? `${message}\n${codeFrame}` : message)
-          } else {
-            /* istanbul ignore next */
-            throw err
   }
-        }
-      },
-      options
-    )
-  )
 
   // The wildcard import results in a huge object with every export
   // with keys that cannot be mangled, and can be quite heavy size-wise.