theluyuan/vue3-yuanma
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

perf(effect): optimize effect trigger for array length mutation (#761)

Browse Source
This commit is contained in:
guaijie 2020-02-22 12:17:30 +08:00 committed by GitHub
parent e9024bf1b7
commit 76c7f54269
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
packages/reactivity/src/effect.ts
View File

@ -176,17 +176,18 @@ export function trigger(
} }
const effects = new Set<ReactiveEffect>() const effects = new Set<ReactiveEffect>()
const computedRunners = new Set<ReactiveEffect>() const computedRunners = new Set<ReactiveEffect>()
if ( if (type === TriggerOpTypes.CLEAR) {
type === TriggerOpTypes.CLEAR || // collection being cleared
(key === 'length' &&
isArray(target) &&
(newValue as number) < (oldValue as number))
) {
// collection being cleared or Array length mutation
// trigger all effects for target // trigger all effects for target
depsMap.forEach(dep => { depsMap.forEach(dep => {
addRunners(effects, computedRunners, dep) addRunners(effects, computedRunners, dep)
}) })
} else if (key === 'length' && isArray(target)) {
depsMap.forEach((dep, key) => {
if (key === 'length' || key >= (newValue as number)) {
addRunners(effects, computedRunners, dep)
}
})
} else { } else {
// schedule runs for SET | ADD | DELETE // schedule runs for SET | ADD | DELETE
if (key !== void 0) { if (key !== void 0) {