wip(ssr): vdom serialization

2020-01-28 18:48:27 -05:00
parent 8857b4f288
commit 6f43c4b516
11 changed files with 286 additions and 48 deletions
--- a/packages/runtime-dom/src/modules/attrs.ts
+++ b/packages/runtime-dom/src/modules/attrs.ts
@@ -1,7 +1,18 @@
-export function patchAttr(el: Element, key: string, value: any) {
-  if (value == null) {
+// TODO explain why we are no longer checking boolean/enumerated here
+
+export function patchAttr(
+  el: Element,
+  key: string,
+  value: any,
+  isSVG: boolean
+) {
+  if (isSVG && key.indexOf('xlink:') === 0) {
+    // TODO handle xlink
+  } else if (value == null) {
    el.removeAttribute(key)
  } else {
+    // TODO in dev mode, warn against incorrect values for boolean or
+    // enumerated attributes
    el.setAttribute(key, value)
  }
 }