theluyuan/vue3-yuanma
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(devtools): fix memory leak when devtools is not installed (#4833)

Browse Source 
fix #4829
This commit is contained in:
Che Guevara 2021-11-02 11:26:40 +08:00 committed by GitHub
parent b5c0142cf0
commit 6b32f0d976
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
packages/runtime-core/src/devtools.ts
View File

@ -33,10 +33,12 @@ export let devtools: DevtoolsHook
let buffer: { event: string; args: any[] }[] = [] let buffer: { event: string; args: any[] }[] = []
let devtoolsNotInstalled = false
function emit(event: string, ...args: any[]) { function emit(event: string, ...args: any[]) {
if (devtools) { if (devtools) {
devtools.emit(event, ...args) devtools.emit(event, ...args)
} else { } else if (!devtoolsNotInstalled) {
buffer.push({ event, args }) buffer.push({ event, args })
} }
} }
@ -56,7 +58,10 @@ export function setDevtoolsHook(hook: DevtoolsHook, target: any) {
// clear buffer after 3s - the user probably doesn't have devtools installed // clear buffer after 3s - the user probably doesn't have devtools installed
// at all, and keeping the buffer will cause memory leaks (#4738) // at all, and keeping the buffer will cause memory leaks (#4738)
setTimeout(() => { setTimeout(() => {
buffer = [] if (!devtools) {
devtoolsNotInstalled = true
buffer = []
}
}, 3000) }, 3000)
} }
} }