fix(ssr): reset current instance (#6184)

fix #6110
This commit is contained in:
似水微寒 2022-09-07 17:08:52 +08:00 committed by GitHub
parent fa6556a0d5
commit 6493da5bfa
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 34 additions and 13 deletions

View File

@ -20,7 +20,8 @@ import {
resolveDynamicComponent, resolveDynamicComponent,
renderSlot, renderSlot,
onErrorCaptured, onErrorCaptured,
onServerPrefetch onServerPrefetch,
getCurrentInstance
} from 'vue' } from 'vue'
import { escapeHtml } from '@vue/shared' import { escapeHtml } from '@vue/shared'
import { renderToString } from '../src/renderToString' import { renderToString } from '../src/renderToString'
@ -779,6 +780,23 @@ function testRender(type: string, render: typeof renderToString) {
).toHaveBeenWarned() ).toHaveBeenWarned()
expect(`Element is missing end tag`).toHaveBeenWarned() expect(`Element is missing end tag`).toHaveBeenWarned()
}) })
// #6110
test('reset current instance after rendering error', async () => {
const prev = getCurrentInstance()
expect(prev).toBe(null)
try {
await render(
createApp({
data() {
return { msg: null }
},
template: `<div>{{ msg.text }}</div>`
})
)
} catch {}
expect(getCurrentInstance()).toBe(prev)
})
}) })
test('serverPrefetch', async () => { test('serverPrefetch', async () => {

View File

@ -174,6 +174,7 @@ function renderComponentSubTree(
// set current rendering instance for asset resolution // set current rendering instance for asset resolution
const prev = setCurrentRenderingInstance(instance) const prev = setCurrentRenderingInstance(instance)
try {
ssrRender( ssrRender(
instance.proxy, instance.proxy,
push, push,
@ -185,7 +186,9 @@ function renderComponentSubTree(
instance.data, instance.data,
instance.ctx instance.ctx
) )
} finally {
setCurrentRenderingInstance(prev) setCurrentRenderingInstance(prev)
}
} else if (instance.render && instance.render !== NOOP) { } else if (instance.render && instance.render !== NOOP) {
renderVNode( renderVNode(
push, push,