fix(runtime-core): v-model listeners that already exists on the component should not be merged (#2011)
fix #1989
This commit is contained in:
@@ -17,6 +17,7 @@ import { handleError, ErrorCodes } from './errorHandling'
|
||||
import { PatchFlags, ShapeFlags, isOn, isModelListener } from '@vue/shared'
|
||||
import { warn } from './warning'
|
||||
import { isHmrUpdating } from './hmr'
|
||||
import { NormalizedProps } from './componentProps'
|
||||
|
||||
// mark the current rendering instance for asset resolution (e.g.
|
||||
// resolveComponent, resolveDirective) during render
|
||||
@@ -46,6 +47,7 @@ export function renderComponentRoot(
|
||||
proxy,
|
||||
withProxy,
|
||||
props,
|
||||
propsOptions: [propsOptions],
|
||||
slots,
|
||||
attrs,
|
||||
emit,
|
||||
@@ -125,11 +127,15 @@ export function renderComponentRoot(
|
||||
shapeFlag & ShapeFlags.ELEMENT ||
|
||||
shapeFlag & ShapeFlags.COMPONENT
|
||||
) {
|
||||
if (shapeFlag & ShapeFlags.ELEMENT && keys.some(isModelListener)) {
|
||||
// #1643, #1543
|
||||
// component v-model listeners should only fallthrough for component
|
||||
// HOCs
|
||||
fallthroughAttrs = filterModelListeners(fallthroughAttrs)
|
||||
if (propsOptions && keys.some(isModelListener)) {
|
||||
// If a v-model listener (onUpdate:xxx) has a corresponding declared
|
||||
// prop, it indicates this component expects to handle v-model and
|
||||
// it should not fallthrough.
|
||||
// related: #1543, #1643, #1989
|
||||
fallthroughAttrs = filterModelListeners(
|
||||
fallthroughAttrs,
|
||||
propsOptions
|
||||
)
|
||||
}
|
||||
root = cloneVNode(root, fallthroughAttrs)
|
||||
} else if (__DEV__ && !accessedAttrs && root.type !== Comment) {
|
||||
@@ -251,10 +257,10 @@ const getFunctionalFallthrough = (attrs: Data): Data | undefined => {
|
||||
return res
|
||||
}
|
||||
|
||||
const filterModelListeners = (attrs: Data): Data => {
|
||||
const filterModelListeners = (attrs: Data, props: NormalizedProps): Data => {
|
||||
const res: Data = {}
|
||||
for (const key in attrs) {
|
||||
if (!isModelListener(key)) {
|
||||
if (!isModelListener(key) || !(key.slice(9) in props)) {
|
||||
res[key] = attrs[key]
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user