fix(suspense): should discard unmount effects of invalidated pending branch

2020-09-17 23:49:06 -04:00
parent 49bb44756f
commit 5bfcad155b
2 changed files with 4 additions and 3 deletions
--- a/packages/runtime-core/src/components/Suspense.ts
+++ b/packages/runtime-core/src/components/Suspense.ts
@@ -201,11 +201,12 @@ function patchSuspense(
        suspense.isHydrating = false
        suspense.activeBranch = pendingBranch
      } else {
-        unmount(pendingBranch, parentComponent, null)
+        unmount(pendingBranch, parentComponent, suspense)
      }
      // increment pending ID. this is used to invalidate async callbacks
      // reset suspense state
      suspense.deps = 0
+      // discard effects from pending branch
      suspense.effects.length = 0
      // discard previous container
      suspense.hiddenContainer = createElement('div')