fix(core): propsProxy should not convert non-reactive nested values

This commit is contained in:
Evan You
2019-12-02 14:11:12 -05:00
parent ac51f129ea
commit 57bbbb227c
6 changed files with 40 additions and 39 deletions

View File

@@ -10,7 +10,7 @@ import {
unlock,
effect,
ref,
readonlyProps
shallowReadonly
} from '../src'
import { mockWarn } from '@vue/runtime-test'
@@ -444,31 +444,31 @@ describe('reactivity/readonly', () => {
).toHaveBeenWarned()
})
describe('readonlyProps', () => {
test('should not unwrap root-level refs', () => {
const props = readonlyProps({ n: ref(1) })
expect(props.n.value).toBe(1)
describe('shallowReadonly', () => {
test('should not make non-reactive properties reactive', () => {
const props = shallowReadonly({ n: { foo: 1 } })
expect(isReactive(props.n)).toBe(false)
})
test('should unwrap nested refs', () => {
const props = readonlyProps({ foo: { bar: ref(1) } })
expect(props.foo.bar).toBe(1)
})
test('should make properties readonly', () => {
const props = readonlyProps({ n: ref(1) })
props.n.value = 2
expect(props.n.value).toBe(1)
expect(
`Set operation on key "value" failed: target is readonly.`
).toHaveBeenWarned()
test('should make root level properties readonly', () => {
const props = shallowReadonly({ n: 1 })
// @ts-ignore
props.n = 2
expect(props.n.value).toBe(1)
expect(props.n).toBe(1)
expect(
`Set operation on key "n" failed: target is readonly.`
).toHaveBeenWarned()
})
// to retain 2.x behavior.
test('should NOT make nested properties readonly', () => {
const props = shallowReadonly({ n: { foo: 1 } })
// @ts-ignore
props.n.foo = 2
expect(props.n.foo).toBe(2)
expect(
`Set operation on key "foo" failed: target is readonly.`
).not.toHaveBeenWarned()
})
})
})