From 51d57b456636e246524aa064a7788dcc7658588d Mon Sep 17 00:00:00 2001 From: Evan You Date: Fri, 15 Nov 2019 16:47:55 -0500 Subject: [PATCH] perf(compiler): minor perf tweaks --- .../transforms/__snapshots__/hoistStatic.spec.ts.snap | 2 +- packages/compiler-core/src/codegen.ts | 3 +-- packages/compiler-core/src/parse.ts | 2 +- .../compiler-dom/__tests__/__snapshots__/index.spec.ts.snap | 2 +- 4 files changed, 4 insertions(+), 5 deletions(-) diff --git a/packages/compiler-core/__tests__/transforms/__snapshots__/hoistStatic.spec.ts.snap b/packages/compiler-core/__tests__/transforms/__snapshots__/hoistStatic.spec.ts.snap index c4dd8cbb..8283cae1 100644 --- a/packages/compiler-core/__tests__/transforms/__snapshots__/hoistStatic.spec.ts.snap +++ b/packages/compiler-core/__tests__/transforms/__snapshots__/hoistStatic.spec.ts.snap @@ -156,7 +156,7 @@ exports[`compiler: hoistStatic transform prefixIdentifiers hoist class with stat "const _Vue = Vue const _createVNode = Vue.createVNode -const _hoisted_1 = { class: { foo: true }} +const _hoisted_1 = { class: { foo: true } } return function render() { with (this) { diff --git a/packages/compiler-core/src/codegen.ts b/packages/compiler-core/src/codegen.ts index 99531868..8baff9cb 100644 --- a/packages/compiler-core/src/codegen.ts +++ b/packages/compiler-core/src/codegen.ts @@ -552,8 +552,7 @@ function genObjectExpression(node: ObjectExpression, context: CodegenContext) { } } multilines && deindent() - const lastChar = context.code[context.code.length - 1] - push(multilines || /[\])}]/.test(lastChar) ? `}` : ` }`) + push(multilines ? `}` : ` }`) } function genArrayExpression(node: ArrayExpression, context: CodegenContext) { diff --git a/packages/compiler-core/src/parse.ts b/packages/compiler-core/src/parse.ts index 1fdc44cc..ee70ecfa 100644 --- a/packages/compiler-core/src/parse.ts +++ b/packages/compiler-core/src/parse.ts @@ -595,7 +595,7 @@ function parseAttribute( let arg: ExpressionNode | undefined if (match[2]) { - const startOffset = name.split(match[2], 2)!.shift()!.length + const startOffset = name.indexOf(match[2]) const loc = getSelection( context, getNewPosition(context, start, startOffset), diff --git a/packages/compiler-dom/__tests__/__snapshots__/index.spec.ts.snap b/packages/compiler-dom/__tests__/__snapshots__/index.spec.ts.snap index eb3ac43f..b26a3e6b 100644 --- a/packages/compiler-dom/__tests__/__snapshots__/index.spec.ts.snap +++ b/packages/compiler-dom/__tests__/__snapshots__/index.spec.ts.snap @@ -15,7 +15,7 @@ return function render() { _createVNode(\\"div\\", { innerHTML: html }, null, 8 /* PROPS */, [\\"innerHTML\\"]), _createVNode(\\"div\\", null, \\"test\\"), _createVNode(\\"div\\", { style: _hoisted_1 }, \\"red\\"), - _createVNode(\\"div\\", { style: {color: 'green'}}, null, 4 /* STYLE */) + _createVNode(\\"div\\", { style: {color: 'green'} }, null, 4 /* STYLE */) ])) } }"