fix(reactivity): remove Symbol.observable (#968)

* chore: add @types/node as an explicit dependency

As `tsconfig.json` references it, it should be listed in the dependencies.
It currently uses an older version: this commit also bumps to the latest v12 version, and fixes a typing issue.

* fix(reactivity): remove Symbol.observable

`Symbol.observable` is brought by `@types/node@12` and is not a "well-known" typescript symbol https://www.typescriptlang.org/docs/handbook/symbols.html that can be find in lib.es20xx like the others. It has been removed in `@types/node@v13`.
It means that an application using vue@3.0.0-alpha.13 does not compile unless it explicitely adds `@types/node@v12` as a dependency and `node` in its own tsconfig types.
This commit is contained in:
Cédric Exbrayat
2020-04-16 15:33:30 +02:00
committed by GitHub
parent d7ae1d0244
commit 4d014dc3d3
5 changed files with 9 additions and 6 deletions

View File

@@ -69,8 +69,8 @@ export const transformAssetUrl: NodeTransform = (
}
function getImportsExpressionExp(
path: string | undefined,
hash: string | undefined,
path: string | null,
hash: string | null,
loc: SourceLocation,
context: TransformContext
): ExpressionNode {

View File

@@ -151,9 +151,6 @@ type SymbolExtract<T> = (T extends { [Symbol.asyncIterator]: infer V }
(T extends { [Symbol.iterator]: infer V } ? { [Symbol.iterator]: V } : {}) &
(T extends { [Symbol.match]: infer V } ? { [Symbol.match]: V } : {}) &
(T extends { [Symbol.matchAll]: infer V } ? { [Symbol.matchAll]: V } : {}) &
(T extends { [Symbol.observable]: infer V }
? { [Symbol.observable]: V }
: {}) &
(T extends { [Symbol.replace]: infer V } ? { [Symbol.replace]: V } : {}) &
(T extends { [Symbol.search]: infer V } ? { [Symbol.search]: V } : {}) &
(T extends { [Symbol.species]: infer V } ? { [Symbol.species]: V } : {}) &

View File

@@ -97,7 +97,7 @@ window.init = () => {
}
}
const sharedEditorOptions: m.editor.IEditorConstructionOptions = {
const sharedEditorOptions: m.editor.IStandaloneEditorConstructionOptions = {
theme: 'vs-dark',
fontSize: 14,
wordWrap: 'on',