fix(compiler-sfc): fix rewrite named export default (#1675)

This commit is contained in:
underfin 2020-07-23 09:00:41 +08:00 committed by GitHub
parent ee6828aa1e
commit 452edb73cb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 54 additions and 3 deletions

View File

@ -0,0 +1,29 @@
import { rewriteDefault } from '../src'
describe('compiler sfc: rewriteDefault', () => {
test('without export default', () => {
expect(rewriteDefault(`export a = {}`, 'script')).toMatchInlineSnapshot(`
"export a = {}
const script = {}"
`)
})
test('rewrite export default', () => {
expect(
rewriteDefault(`export default {}`, 'script')
).toMatchInlineSnapshot(`"const script = {}"`)
})
test('rewrite export named default', () => {
expect(
rewriteDefault(
`const a = 1 \n export { a as b, a as default, a as c}`,
'script'
)
).toMatchInlineSnapshot(`
"const a = 1
export { a as b, a as c}
const script = a"
`)
})
})

View File

@ -1,7 +1,8 @@
import { parse, ParserPlugin } from '@babel/parser' import { parse, ParserPlugin } from '@babel/parser'
import MagicString from 'magic-string' import MagicString from 'magic-string'
const defaultExportRE = /((?:^|\n|;)\s*)export default/ const defaultExportRE = /((?:^|\n|;)\s*)export(\s*)default/
const namedDefaultExportRE = /((?:^|\n|;)\s*)export(.+)as(\s*)default/
/** /**
* Utility for rewriting `export default` in a script block into a varaible * Utility for rewriting `export default` in a script block into a varaible
@ -12,12 +13,12 @@ export function rewriteDefault(
as: string, as: string,
parserPlugins?: ParserPlugin[] parserPlugins?: ParserPlugin[]
): string { ): string {
if (!defaultExportRE.test(input)) { if (!hasDefaultExport(input)) {
return input + `\nconst ${as} = {}` return input + `\nconst ${as} = {}`
} }
const replaced = input.replace(defaultExportRE, `$1const ${as} =`) const replaced = input.replace(defaultExportRE, `$1const ${as} =`)
if (!defaultExportRE.test(replaced)) { if (!hasDefaultExport(replaced)) {
return replaced return replaced
} }
@ -25,12 +26,33 @@ export function rewriteDefault(
// multi-line comments or template strings. fallback to a full parse. // multi-line comments or template strings. fallback to a full parse.
const s = new MagicString(input) const s = new MagicString(input)
const ast = parse(input, { const ast = parse(input, {
sourceType: 'module',
plugins: parserPlugins plugins: parserPlugins
}).program.body }).program.body
ast.forEach(node => { ast.forEach(node => {
if (node.type === 'ExportDefaultDeclaration') { if (node.type === 'ExportDefaultDeclaration') {
s.overwrite(node.start!, node.declaration.start!, `const ${as} = `) s.overwrite(node.start!, node.declaration.start!, `const ${as} = `)
} }
if (node.type === 'ExportNamedDeclaration') {
node.specifiers.forEach(specifier => {
if (
specifier.type === 'ExportSpecifier' &&
specifier.exported.name === 'default'
) {
const end = specifier.end!
s.overwrite(
specifier.start!,
input.charAt(end) === ',' ? end + 1 : end,
``
)
s.append(`\nconst ${as} = ${specifier.local.name}`)
}
})
}
}) })
return s.toString() return s.toString()
} }
export function hasDefaultExport(input: string): boolean {
return defaultExportRE.test(input) || namedDefaultExportRE.test(input)
}