theluyuan/vue3-yuanma
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(v-model): consistent nullish value handling with 2.x (#1530)

Browse Source 
fix #1528
This commit is contained in:
underfin 2020-07-07 07:02:33 +08:00 committed by GitHub
parent 441c23602f
commit 425335c28b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/runtime-dom/__tests__/directives/vModel.spec.ts
View File

@ -48,6 +48,7 @@ describe('vModel', () => {
const input = root.querySelector('input')! const input = root.querySelector('input')!
const data = root._vnode.component.data const data = root._vnode.component.data
expect(input.value).toEqual('')
input.value = 'foo' input.value = 'foo'
triggerEvent('input', input) triggerEvent('input', input)
@ -57,6 +58,10 @@ describe('vModel', () => {
data.value = 'bar' data.value = 'bar'
await nextTick() await nextTick()
expect(input.value).toEqual('bar') expect(input.value).toEqual('bar')
data.value = undefined
await nextTick()
expect(input.value).toEqual('')
}) })
it('should work with multiple listeners', async () => { it('should work with multiple listeners', async () => {

4
packages/runtime-dom/src/directives/vModel.ts
View File

@ -47,7 +47,7 @@ export const vModelText: ModelDirective<
HTMLInputElement | HTMLTextAreaElement HTMLInputElement | HTMLTextAreaElement
> = { > = {
beforeMount(el, { value, modifiers: { lazy, trim, number } }, vnode) { beforeMount(el, { value, modifiers: { lazy, trim, number } }, vnode) {
el.value = value el.value = value == null ? '' : value
el._assign = getModelAssigner(vnode) el._assign = getModelAssigner(vnode)
const castToNumber = number || el.type === 'number' const castToNumber = number || el.type === 'number'
addEventListener(el, lazy ? 'change' : 'input', e => { addEventListener(el, lazy ? 'change' : 'input', e => {
@ -85,7 +85,7 @@ export const vModelText: ModelDirective<
return return
} }
} }
el.value = value el.value = value == null ? '' : value
} }
} }