theluyuan/vue3-yuanma
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(runtime-dom): capture errors when setting value for IDL (#3578)

Browse Source 
fix #3576
This commit is contained in:
HcySunYang 2021-07-16 04:32:25 +08:00 committed by GitHub
parent 18911abb91
commit 3756270272
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/runtime-dom/__tests__/patchProps.spec.ts
View File

@ -170,4 +170,12 @@ describe('runtime-dom: props patching', () => {
// see https://github.com/vuejs/vue-next/issues/2766 // see https://github.com/vuejs/vue-next/issues/2766
patchProp(el, 'type', 'text', null) patchProp(el, 'type', 'text', null)
}) })
test('input with size', () => {
const el = document.createElement('input')
patchProp(el, 'size', null, 100)
expect(el.size).toBe(100)
patchProp(el, 'size', 100, null)
expect(el.getAttribute('size')).toBe(null)
})
}) })

3
packages/runtime-dom/src/modules/props.ts
View File

@ -52,7 +52,10 @@ export function patchDOMProp(
return return
} else if (type === 'number') { } else if (type === 'number') {
// e.g. <img :width="null"> // e.g. <img :width="null">
// the value of some IDL attr must be greater than 0, e.g. input.size = 0 -> error
try {
el[key] = 0 el[key] = 0
} catch {}
el.removeAttribute(key) el.removeAttribute(key)
return return
} }