theluyuan/vue3-yuanma
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(runtime-core): fix emit listener check on kebab-case events (#2542)

Browse Source 
fix #2540
This commit is contained in:
shadowings-zy 2020-11-28 04:24:29 +08:00 committed by GitHub
parent 2ab8c41a1a
commit 3532b2b021
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
packages/runtime-core/__tests__/componentEmits.spec.ts
View File

@ -283,12 +283,23 @@ describe('component: emit', () => {
}) })
test('isEmitListener', () => { test('isEmitListener', () => {
const options = { click: null } const options = {
click: null,
'test-event': null,
fooBar: null,
FooBaz: null
}
expect(isEmitListener(options, 'onClick')).toBe(true) expect(isEmitListener(options, 'onClick')).toBe(true)
expect(isEmitListener(options, 'onclick')).toBe(false) expect(isEmitListener(options, 'onclick')).toBe(false)
expect(isEmitListener(options, 'onBlick')).toBe(false) expect(isEmitListener(options, 'onBlick')).toBe(false)
// .once listeners // .once listeners
expect(isEmitListener(options, 'onClickOnce')).toBe(true) expect(isEmitListener(options, 'onClickOnce')).toBe(true)
expect(isEmitListener(options, 'onclickOnce')).toBe(false) expect(isEmitListener(options, 'onclickOnce')).toBe(false)
// kebab-case option
expect(isEmitListener(options, 'onTestEvent')).toBe(true)
// camelCase option
expect(isEmitListener(options, 'onFooBar')).toBe(true)
// PascalCase option
expect(isEmitListener(options, 'onFooBaz')).toBe(true)
}) })
}) })

7
packages/runtime-core/src/componentEmits.ts
View File

@ -201,9 +201,10 @@ export function isEmitListener(
if (!options || !isOn(key)) { if (!options || !isOn(key)) {
return false return false
} }
key = key.replace(/Once$/, '') key = key.slice(2).replace(/Once$/, '')
return ( return (
hasOwn(options, key[2].toLowerCase() + key.slice(3)) || hasOwn(options, key[0].toLowerCase() + key.slice(1)) ||
hasOwn(options, key.slice(2)) hasOwn(options, hyphenate(key)) ||
hasOwn(options, key)
) )
} }