refactor(reactivity): make readonly non-tracking
This commit is contained in:
@@ -1,7 +1,6 @@
|
||||
import { reactive, readonly, toRaw } from './reactive'
|
||||
import { TrackOpTypes, TriggerOpTypes } from './operations'
|
||||
import { track, trigger, ITERATE_KEY } from './effect'
|
||||
import { LOCKED } from './lock'
|
||||
import { isObject, hasOwn, isSymbol, hasChanged, isArray } from '@vue/shared'
|
||||
import { isRef } from './ref'
|
||||
|
||||
@@ -12,7 +11,7 @@ const builtInSymbols = new Set(
|
||||
)
|
||||
|
||||
const get = /*#__PURE__*/ createGetter()
|
||||
const shallowReactiveGet = /*#__PURE__*/ createGetter(false, true)
|
||||
const shallowGet = /*#__PURE__*/ createGetter(false, true)
|
||||
const readonlyGet = /*#__PURE__*/ createGetter(true)
|
||||
const shallowReadonlyGet = /*#__PURE__*/ createGetter(true, true)
|
||||
|
||||
@@ -41,57 +40,47 @@ function createGetter(isReadonly = false, shallow = false) {
|
||||
return Reflect.get(arrayInstrumentations, key, receiver)
|
||||
}
|
||||
const res = Reflect.get(target, key, receiver)
|
||||
|
||||
if (isSymbol(key) && builtInSymbols.has(key)) {
|
||||
return res
|
||||
}
|
||||
|
||||
if (shallow) {
|
||||
track(target, TrackOpTypes.GET, key)
|
||||
// TODO strict mode that returns a shallow-readonly version of the value
|
||||
!isReadonly && track(target, TrackOpTypes.GET, key)
|
||||
return res
|
||||
}
|
||||
|
||||
if (isRef(res)) {
|
||||
if (targetIsArray) {
|
||||
track(target, TrackOpTypes.GET, key)
|
||||
!isReadonly && track(target, TrackOpTypes.GET, key)
|
||||
return res
|
||||
} else {
|
||||
// ref unwrapping, only for Objects, not for Arrays.
|
||||
return res.value
|
||||
}
|
||||
} else {
|
||||
track(target, TrackOpTypes.GET, key)
|
||||
return isObject(res)
|
||||
? isReadonly
|
||||
? // need to lazy access readonly and reactive here to avoid
|
||||
// circular dependency
|
||||
readonly(res)
|
||||
: reactive(res)
|
||||
: res
|
||||
}
|
||||
|
||||
!isReadonly && track(target, TrackOpTypes.GET, key)
|
||||
return isObject(res)
|
||||
? isReadonly
|
||||
? // need to lazy access readonly and reactive here to avoid
|
||||
// circular dependency
|
||||
readonly(res)
|
||||
: reactive(res)
|
||||
: res
|
||||
}
|
||||
}
|
||||
|
||||
const set = /*#__PURE__*/ createSetter()
|
||||
const shallowReactiveSet = /*#__PURE__*/ createSetter(false, true)
|
||||
const readonlySet = /*#__PURE__*/ createSetter(true)
|
||||
const shallowReadonlySet = /*#__PURE__*/ createSetter(true, true)
|
||||
const shallowSet = /*#__PURE__*/ createSetter(true)
|
||||
|
||||
function createSetter(isReadonly = false, shallow = false) {
|
||||
function createSetter(shallow = false) {
|
||||
return function set(
|
||||
target: object,
|
||||
key: string | symbol,
|
||||
value: unknown,
|
||||
receiver: object
|
||||
): boolean {
|
||||
if (isReadonly && LOCKED) {
|
||||
if (__DEV__) {
|
||||
console.warn(
|
||||
`Set operation on key "${String(key)}" failed: target is readonly.`,
|
||||
target
|
||||
)
|
||||
}
|
||||
return true
|
||||
}
|
||||
|
||||
const oldValue = (target as any)[key]
|
||||
if (!shallow) {
|
||||
value = toRaw(value)
|
||||
@@ -148,30 +137,32 @@ export const mutableHandlers: ProxyHandler<object> = {
|
||||
|
||||
export const readonlyHandlers: ProxyHandler<object> = {
|
||||
get: readonlyGet,
|
||||
set: readonlySet,
|
||||
has,
|
||||
ownKeys,
|
||||
deleteProperty(target: object, key: string | symbol): boolean {
|
||||
if (LOCKED) {
|
||||
if (__DEV__) {
|
||||
console.warn(
|
||||
`Delete operation on key "${String(
|
||||
key
|
||||
)}" failed: target is readonly.`,
|
||||
target
|
||||
)
|
||||
}
|
||||
return true
|
||||
} else {
|
||||
return deleteProperty(target, key)
|
||||
set(target, key) {
|
||||
if (__DEV__) {
|
||||
console.warn(
|
||||
`Set operation on key "${String(key)}" failed: target is readonly.`,
|
||||
target
|
||||
)
|
||||
}
|
||||
return true
|
||||
},
|
||||
deleteProperty(target, key) {
|
||||
if (__DEV__) {
|
||||
console.warn(
|
||||
`Delete operation on key "${String(key)}" failed: target is readonly.`,
|
||||
target
|
||||
)
|
||||
}
|
||||
return true
|
||||
}
|
||||
}
|
||||
|
||||
export const shallowReactiveHandlers: ProxyHandler<object> = {
|
||||
...mutableHandlers,
|
||||
get: shallowReactiveGet,
|
||||
set: shallowReactiveSet
|
||||
get: shallowGet,
|
||||
set: shallowSet
|
||||
}
|
||||
|
||||
// Props handlers are special in the sense that it should not unwrap top-level
|
||||
@@ -179,6 +170,5 @@ export const shallowReactiveHandlers: ProxyHandler<object> = {
|
||||
// retain the reactivity of the normal readonly object.
|
||||
export const shallowReadonlyHandlers: ProxyHandler<object> = {
|
||||
...readonlyHandlers,
|
||||
get: shallowReadonlyGet,
|
||||
set: shallowReadonlySet
|
||||
get: shallowReadonlyGet
|
||||
}
|
||||
|
||||
@@ -1,7 +1,6 @@
|
||||
import { toRaw, reactive, readonly } from './reactive'
|
||||
import { track, trigger, ITERATE_KEY, MAP_KEY_ITERATE_KEY } from './effect'
|
||||
import { TrackOpTypes, TriggerOpTypes } from './operations'
|
||||
import { LOCKED } from './lock'
|
||||
import {
|
||||
isObject,
|
||||
capitalize,
|
||||
@@ -142,7 +141,7 @@ function createForEach(isReadonly: boolean) {
|
||||
const observed = this
|
||||
const target = toRaw(observed)
|
||||
const wrap = isReadonly ? toReadonly : toReactive
|
||||
track(target, TrackOpTypes.ITERATE, ITERATE_KEY)
|
||||
!isReadonly && track(target, TrackOpTypes.ITERATE, ITERATE_KEY)
|
||||
// important: create sure the callback is
|
||||
// 1. invoked with the reactive map as `this` and 3rd arg
|
||||
// 2. the value received should be a corresponding reactive/readonly.
|
||||
@@ -161,11 +160,12 @@ function createIterableMethod(method: string | symbol, isReadonly: boolean) {
|
||||
const isKeyOnly = method === 'keys' && isMap
|
||||
const innerIterator = getProto(target)[method].apply(target, args)
|
||||
const wrap = isReadonly ? toReadonly : toReactive
|
||||
track(
|
||||
target,
|
||||
TrackOpTypes.ITERATE,
|
||||
isKeyOnly ? MAP_KEY_ITERATE_KEY : ITERATE_KEY
|
||||
)
|
||||
!isReadonly &&
|
||||
track(
|
||||
target,
|
||||
TrackOpTypes.ITERATE,
|
||||
isKeyOnly ? MAP_KEY_ITERATE_KEY : ITERATE_KEY
|
||||
)
|
||||
// return a wrapped iterator which returns observed versions of the
|
||||
// values emitted from the real iterator
|
||||
return {
|
||||
@@ -187,23 +187,16 @@ function createIterableMethod(method: string | symbol, isReadonly: boolean) {
|
||||
}
|
||||
}
|
||||
|
||||
function createReadonlyMethod(
|
||||
method: Function,
|
||||
type: TriggerOpTypes
|
||||
): Function {
|
||||
function createReadonlyMethod(type: TriggerOpTypes): Function {
|
||||
return function(this: CollectionTypes, ...args: unknown[]) {
|
||||
if (LOCKED) {
|
||||
if (__DEV__) {
|
||||
const key = args[0] ? `on key "${args[0]}" ` : ``
|
||||
console.warn(
|
||||
`${capitalize(type)} operation ${key}failed: target is readonly.`,
|
||||
toRaw(this)
|
||||
)
|
||||
}
|
||||
return type === TriggerOpTypes.DELETE ? false : this
|
||||
} else {
|
||||
return method.apply(this, args)
|
||||
if (__DEV__) {
|
||||
const key = args[0] ? `on key "${args[0]}" ` : ``
|
||||
console.warn(
|
||||
`${capitalize(type)} operation ${key}failed: target is readonly.`,
|
||||
toRaw(this)
|
||||
)
|
||||
}
|
||||
return type === TriggerOpTypes.DELETE ? false : this
|
||||
}
|
||||
}
|
||||
|
||||
@@ -230,10 +223,10 @@ const readonlyInstrumentations: Record<string, Function> = {
|
||||
return size((this as unknown) as IterableCollections)
|
||||
},
|
||||
has,
|
||||
add: createReadonlyMethod(add, TriggerOpTypes.ADD),
|
||||
set: createReadonlyMethod(set, TriggerOpTypes.SET),
|
||||
delete: createReadonlyMethod(deleteEntry, TriggerOpTypes.DELETE),
|
||||
clear: createReadonlyMethod(clear, TriggerOpTypes.CLEAR),
|
||||
add: createReadonlyMethod(TriggerOpTypes.ADD),
|
||||
set: createReadonlyMethod(TriggerOpTypes.SET),
|
||||
delete: createReadonlyMethod(TriggerOpTypes.DELETE),
|
||||
clear: createReadonlyMethod(TriggerOpTypes.CLEAR),
|
||||
forEach: createForEach(true)
|
||||
}
|
||||
|
||||
|
||||
@@ -40,5 +40,4 @@ export {
|
||||
ReactiveEffectOptions,
|
||||
DebuggerEvent
|
||||
} from './effect'
|
||||
export { lock, unlock } from './lock'
|
||||
export { TrackOpTypes, TriggerOpTypes } from './operations'
|
||||
|
||||
@@ -1,10 +0,0 @@
|
||||
// global immutability lock
|
||||
export let LOCKED = true
|
||||
|
||||
export function lock() {
|
||||
LOCKED = true
|
||||
}
|
||||
|
||||
export function unlock() {
|
||||
LOCKED = false
|
||||
}
|
||||
@@ -2,8 +2,8 @@ import { isObject, toRawType } from '@vue/shared'
|
||||
import {
|
||||
mutableHandlers,
|
||||
readonlyHandlers,
|
||||
shallowReadonlyHandlers,
|
||||
shallowReactiveHandlers
|
||||
shallowReactiveHandlers,
|
||||
shallowReadonlyHandlers
|
||||
} from './baseHandlers'
|
||||
import {
|
||||
mutableCollectionHandlers,
|
||||
@@ -55,14 +55,22 @@ export function reactive(target: object) {
|
||||
)
|
||||
}
|
||||
|
||||
// Return a reactive-copy of the original object, where only the root level
|
||||
// properties are reactive, and does NOT unwrap refs nor recursively convert
|
||||
// returned properties.
|
||||
export function shallowReactive<T extends object>(target: T): T {
|
||||
return createReactiveObject(
|
||||
target,
|
||||
rawToReactive,
|
||||
reactiveToRaw,
|
||||
shallowReactiveHandlers,
|
||||
mutableCollectionHandlers
|
||||
)
|
||||
}
|
||||
|
||||
export function readonly<T extends object>(
|
||||
target: T
|
||||
): Readonly<UnwrapNestedRefs<T>> {
|
||||
// value is a mutable observable, retrieve its original and return
|
||||
// a readonly version.
|
||||
if (reactiveToRaw.has(target)) {
|
||||
target = reactiveToRaw.get(target)
|
||||
}
|
||||
return createReactiveObject(
|
||||
target,
|
||||
rawToReadonly,
|
||||
@@ -88,19 +96,6 @@ export function shallowReadonly<T extends object>(
|
||||
)
|
||||
}
|
||||
|
||||
// Return a reactive-copy of the original object, where only the root level
|
||||
// properties are reactive, and does NOT unwrap refs nor recursively convert
|
||||
// returned properties.
|
||||
export function shallowReactive<T extends object>(target: T): T {
|
||||
return createReactiveObject(
|
||||
target,
|
||||
rawToReactive,
|
||||
reactiveToRaw,
|
||||
shallowReactiveHandlers,
|
||||
mutableCollectionHandlers
|
||||
)
|
||||
}
|
||||
|
||||
function createReactiveObject(
|
||||
target: unknown,
|
||||
toProxy: WeakMap<any, any>,
|
||||
@@ -145,7 +140,8 @@ export function isReadonly(value: unknown): boolean {
|
||||
}
|
||||
|
||||
export function toRaw<T>(observed: T): T {
|
||||
return reactiveToRaw.get(observed) || readonlyToRaw.get(observed) || observed
|
||||
observed = readonlyToRaw.get(observed) || observed
|
||||
return reactiveToRaw.get(observed) || observed
|
||||
}
|
||||
|
||||
export function markNonReactive<T extends object>(value: T): T {
|
||||
|
||||
Reference in New Issue
Block a user