theluyuan/vue3-yuanma
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(ssr): ensure async setup error handling work with suspense during ssr

Browse Source
This commit is contained in:
Evan You
2021-03-26 11:00:30 -04:00
parent d668d48e9e
commit 2e71f07bc1
4 changed files with 22 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
packages/server-renderer/__tests__/ssrSuspense.spec.ts
View File

@@ -29,6 +29,7 @@ describe('SSR Suspense', () => {
test('reject', async () => {
const Comp = {
errorCaptured: jest.fn(() => false),
render() {
return h(Suspense, null, {
default: h(RejectingAsync),
@@ -38,10 +39,8 @@ describe('SSR Suspense', () => {
}
expect(await renderToString(createApp(Comp))).toBe(`<!---->`)
expect('Uncaught error in async setup').toHaveBeenWarned()
expect(
'Unhandled error during execution of setup function'
).toHaveBeenWarned()
expect(Comp.errorCaptured).toHaveBeenCalledTimes(1)
expect('missing template').toHaveBeenWarned()
})
@@ -62,6 +61,7 @@ describe('SSR Suspense', () => {
test('resolving component + rejecting component', async () => {
const Comp = {
errorCaptured: jest.fn(() => false),
render() {
return h(Suspense, null, {
default: h('div', [h(ResolvingAsync), h(RejectingAsync)]),
@@ -73,15 +73,14 @@ describe('SSR Suspense', () => {
expect(await renderToString(createApp(Comp))).toBe(
`<div><div>async</div><!----></div>`
)
expect('Uncaught error in async setup').toHaveBeenWarned()
expect(
'Unhandled error during execution of setup function'
).toHaveBeenWarned()
expect(Comp.errorCaptured).toHaveBeenCalledTimes(1)
expect('missing template or render function').toHaveBeenWarned()
})
test('failing suspense in passing suspense', async () => {
const Comp = {
errorCaptured: jest.fn(() => false),
render() {
return h(Suspense, null, {
default: h('div', [
@@ -99,15 +98,14 @@ describe('SSR Suspense', () => {
expect(await renderToString(createApp(Comp))).toBe(
`<div><div>async</div><div><!----></div></div>`
)
expect('Uncaught error in async setup').toHaveBeenWarned()
expect(
'Unhandled error during execution of setup function'
).toHaveBeenWarned()
expect(Comp.errorCaptured).toHaveBeenCalledTimes(1)
expect('missing template').toHaveBeenWarned()
})
test('passing suspense in failing suspense', async () => {
const Comp = {
errorCaptured: jest.fn(() => false),
render() {
return h(Suspense, null, {
default: h('div', [
@@ -125,10 +123,7 @@ describe('SSR Suspense', () => {
expect(await renderToString(createApp(Comp))).toBe(
`<div><!----><div><div>async</div></div></div>`
)
expect('Uncaught error in async setup').toHaveBeenWarned()
expect(
'Unhandled error during execution of setup function'
).toHaveBeenWarned()
expect(Comp.errorCaptured).toHaveBeenCalledTimes(1)
expect('missing template').toHaveBeenWarned()
})
})