fix(reactivity): call array subclass methods (#3624)

fix #2314, close #2315
This commit is contained in:
TheDro
2021-07-15 17:17:13 -04:00
committed by GitHub
parent 299f7c08c7
commit 1cfe290352
2 changed files with 45 additions and 6 deletions

View File

@@ -49,17 +49,16 @@ function createArrayInstrumentations() {
// instrument identity-sensitive Array methods to account for possible reactive
// values
;(['includes', 'indexOf', 'lastIndexOf'] as const).forEach(key => {
const method = Array.prototype[key] as any
instrumentations[key] = function(this: unknown[], ...args: unknown[]) {
const arr = toRaw(this)
const arr = toRaw(this) as any
for (let i = 0, l = this.length; i < l; i++) {
track(arr, TrackOpTypes.GET, i + '')
}
// we run the method using the original args first (which may be reactive)
const res = method.apply(arr, args)
const res = arr[key](...args)
if (res === -1 || res === false) {
// if that didn't work, run it again using raw values.
return method.apply(arr, args.map(toRaw))
return arr[key](...args.map(toRaw))
} else {
return res
}
@@ -68,10 +67,9 @@ function createArrayInstrumentations() {
// instrument length-altering mutation methods to avoid length being tracked
// which leads to infinite loops in some cases (#2137)
;(['push', 'pop', 'shift', 'unshift', 'splice'] as const).forEach(key => {
const method = Array.prototype[key] as any
instrumentations[key] = function(this: unknown[], ...args: unknown[]) {
pauseTracking()
const res = method.apply(this, args)
const res = (toRaw(this) as any)[key].apply(this, args)
resetTracking()
return res
}