fix(reactivity): dereference nested effect scopes on manual stop

2021-07-28 12:08:01 -04:00
parent da6c055b19
commit 1867591e7c
2 changed files with 16 additions and 2 deletions
--- a/packages/reactivity/tests/effectScope.spec.ts
+++ b/packages/reactivity/tests/effectScope.spec.ts
@@ -191,6 +191,14 @@ describe('reactivity/effect/scope', () => {
    expect(dummy).toBe(7)
  })

+  it('should derefence child scope from parent scope after stopping child scope (no memleaks)', async () => {
+    const parent = new EffectScope()
+    const child = parent.run(() => new EffectScope())!
+    expect(parent.effects.includes(child)).toBe(true)
+    child.stop()
+    expect(parent.effects.includes(child)).toBe(false)
+  })
+
  it('test with higher level APIs', async () => {
    const r = ref(1)