refactor(compiler-sfc): adjust sfc compileScript usage

packages/compiler-sfc/__tests__/compileScript.spec.ts

@@ -1,9 +1,10 @@
-import { parse, SFCScriptCompileOptions } from '../src'
+import { parse, SFCScriptCompileOptions, compileScript } from '../src'
 import { parse as babelParse } from '@babel/parser'
 import { babelParserDefautPlugins } from '@vue/shared'
 
 function compile(src: string, options?: SFCScriptCompileOptions) {
-  return parse(src, options).descriptor.scriptTransformed!
+  const { descriptor } = parse(src)
+  return compileScript(descriptor, options)
 }
 
 function assertCode(code: string) {
@@ -370,24 +371,23 @@ describe('SFC compile <script setup>', () => {
 
   describe('errors', () => {
     test('<script> and <script setup> must have same lang', () => {
-      expect(
+      expect(() =>
-        parse(`<script>foo()</script><script setup lang="ts">bar()</script>`)
+        compile(`<script>foo()</script><script setup lang="ts">bar()</script>`)
-          .errors[0].message
+      ).toThrow(`<script> and <script setup> must have the same language type`)
-      ).toMatch(`<script> and <script setup> must have the same language type`)
     })
 
     test('export local as default', () => {
-      expect(
+      expect(() =>
-        parse(`<script setup>
+        compile(`<script setup>
           const bar = 1
           export { bar as default }
-        </script>`).errors[0].message
+        </script>`)
-      ).toMatch(`Cannot export locally defined variable as default`)
+      ).toThrow(`Cannot export locally defined variable as default`)
     })
 
     test('export default referencing local var', () => {
-      expect(
+      expect(() =>
-        parse(`<script setup>
+        compile(`<script setup>
           const bar = 1
           export default {
             props: {
@@ -396,19 +396,19 @@ describe('SFC compile <script setup>', () => {
               }
             }
           }
-        </script>`).errors[0].message
+        </script>`)
-      ).toMatch(`cannot reference locally declared variables`)
+      ).toThrow(`cannot reference locally declared variables`)
     })
 
     test('export default referencing exports', () => {
-      expect(
+      expect(() =>
-        parse(`<script setup>
+        compile(`<script setup>
         export const bar = 1
         export default {
           props: bar
         }
-      </script>`).errors[0].message
+      </script>`)
-      ).toMatch(`cannot reference locally declared variables`)
+      ).toThrow(`cannot reference locally declared variables`)
     })
 
     test('should allow export default referencing scope var', () => {
@@ -458,19 +458,19 @@ describe('SFC compile <script setup>', () => {
     })
 
     test('error on duplicated default export', () => {
-      expect(
+      expect(() =>
-        parse(`
+        compile(`
       <script>
       export default {}
       </script>
       <script setup>
       export default {}
       </script>
-      `).errors[0].message
+      `)
-      ).toMatch(`Default export is already declared`)
+      ).toThrow(`Default export is already declared`)
 
-      expect(
+      expect(() =>
-        parse(`
+        compile(`
       <script>
       export default {}
       </script>
@@ -478,33 +478,33 @@ describe('SFC compile <script setup>', () => {
       const x = {}
       export { x as default }
       </script>
-      `).errors[0].message
+      `)
-      ).toMatch(`Default export is already declared`)
+      ).toThrow(`Default export is already declared`)
 
-      expect(
+      expect(() =>
-        parse(`
+        compile(`
       <script>
       export default {}
       </script>
       <script setup>
       export { x as default } from './y'
       </script>
-      `).errors[0].message
+      `)
-      ).toMatch(`Default export is already declared`)
+      ).toThrow(`Default export is already declared`)
 
-      expect(
+      expect(() =>
-        parse(`
+        compile(`
       <script>
       export { x as default } from './y'
       </script>
       <script setup>
       export default {}
       </script>
-      `).errors[0].message
+      `)
-      ).toMatch(`Default export is already declared`)
+      ).toThrow(`Default export is already declared`)
 
-      expect(
+      expect(() =>
-        parse(`
+        compile(`
       <script>
       const x = {}
       export { x as default }
@@ -512,8 +512,8 @@ describe('SFC compile <script setup>', () => {
       <script setup>
       export default {}
       </script>
-      `).errors[0].message
+      `)
-      ).toMatch(`Default export is already declared`)
+      ).toThrow(`Default export is already declared`)
     })
   })
 })

packages/compiler-sfc/src/parse.ts

@@ -9,9 +9,8 @@ import {
 import * as CompilerDOM from '@vue/compiler-dom'
 import { RawSourceMap, SourceMapGenerator } from 'source-map'
 import { TemplateCompiler } from './compileTemplate'
-import { compileScript, SFCScriptCompileOptions } from './compileScript'
 
-export interface SFCParseOptions extends SFCScriptCompileOptions {
+export interface SFCParseOptions {
   filename?: string
   sourceMap?: boolean
   sourceRoot?: string
@@ -53,7 +52,6 @@ export interface SFCDescriptor {
   template: SFCTemplateBlock | null
   script: SFCScriptBlock | null
   scriptSetup: SFCScriptBlock | null
-  scriptTransformed: SFCScriptBlock | null
   styles: SFCStyleBlock[]
   customBlocks: SFCBlock[]
 }
@@ -79,8 +77,7 @@ export function parse(
     filename = 'component.vue',
     sourceRoot = '',
     pad = false,
-    compiler = CompilerDOM,
+    compiler = CompilerDOM
-    babelParserPlugins
   }: SFCParseOptions = {}
 ): SFCParseResult {
   const sourceKey =
@@ -96,7 +93,6 @@ export function parse(
     template: null,
     script: null,
     scriptSetup: null,
-    scriptTransformed: null,
     styles: [],
     customBlocks: []
   }
@@ -198,16 +194,6 @@ export function parse(
     descriptor.styles.forEach(genMap)
   }
 
-  if (descriptor.script || descriptor.scriptSetup) {
-    try {
-      descriptor.scriptTransformed = compileScript(descriptor, {
-        babelParserPlugins
-      })
-    } catch (e) {
-      errors.push(e)
-    }
-  }
-
   const result = {
     descriptor,
     errors